Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mg_head #49

Merged
merged 70 commits into from
Sep 19, 2020
Merged

Add mg_head #49

merged 70 commits into from
Sep 19, 2020

Conversation

yinchimaoliang
Copy link
Contributor

Add CenterHead and related module.

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #49 into master will decrease coverage by 0.44%.
The diff coverage is 46.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   51.53%   51.08%   -0.45%     
==========================================
  Files         140      144       +4     
  Lines        8521     8958     +437     
  Branches     1323     1388      +65     
==========================================
+ Hits         4391     4576     +185     
- Misses       3850     4091     +241     
- Partials      280      291      +11     
Flag Coverage Δ
#unittests 51.08% <46.45%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/utils/gaussian.py 13.15% <13.15%> (ø)
mmdet3d/core/post_processing/box3d_nms.py 51.48% <16.66%> (-10.86%) ⬇️
mmdet3d/ops/iou3d/iou3d_utils.py 22.72% <20.00%> (-5.06%) ⬇️
mmdet3d/models/losses/centerpoint_focal_loss.py 38.09% <38.09%> (ø)
...3d/models/roi_heads/bbox_heads/multi_group_head.py 41.61% <41.61%> (ø)
...mdet3d/core/bbox/coders/centerpoint_bbox_coders.py 84.26% <84.26%> (ø)
mmdet3d/core/__init__.py 100.00% <100.00%> (ø)
mmdet3d/core/bbox/coders/__init__.py 100.00% <100.00%> (ø)
mmdet3d/core/post_processing/__init__.py 100.00% <100.00%> (ø)
mmdet3d/core/utils/__init__.py 100.00% <100.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b09115...c92e161. Read the comment docs.

@@ -733,14 +729,8 @@ def get_task_detections(self, num_class_with_bg, batch_cls_preds,
box_preds = box_preds.float()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are 729 -730 necessary?

# encode background as first element in one-hot vector
total_scores = torch.sigmoid(cls_preds)[..., 1:]
# total_scores = torch.sigmoid(cls_preds)
total_scores = cls_preds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are the same, we may skip this assignment and only use cls_preds in the following code

@ZwwWayne ZwwWayne merged commit d07bd8b into open-mmlab:master Sep 19, 2020
@ZwwWayne ZwwWayne mentioned this pull request Sep 20, 2020
7 tasks
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* first

* fix0

* fix1

* dirty work

* wip

* add allocator

* finally done!

* lint

* fix lint

* better gather

* better onnx2ncnn

* fix expand

* [Fix] NCNN TensorSlice op bugs (open-mmlab#42)

* fix custom ops support, fix multiple mark bug, add name mapping

* check if the value_info need to be added

* remove unnecessary print

* add nms implement

* two stage split wip

* add two stage split

* add split retinanet visualize

* add two stage split (wip)

* finish two stage split

* fix lint

* move parse string to mmdeploy.utils

* add calib data generator

* create calib dataset

* finish end2end int8

* add split two stage tensorrt visualize

* fix tensorslice bugs

* fix lint

* fix clang-format

* remove comments

* int param

* fix lint

Co-authored-by: grimoire <[email protected]>

* add two stage ncnn support

* remove unused ops

* git unused config

* remove no_grad, should add in refactor

* add ncnn wrapper

* fix lint

* size return tuple

* Resolve grammar error

* Fix lint

* Trim Trailing Whitespace

* fix trim

* update wrapper

* remove logs

* remove

* csrc optimize

Co-authored-by: hanrui1sensetime <[email protected]>
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants