Fixed issue unpacking size in furthest_point_sample #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tuple unpacked into three arguments when four were given when running VoteNet on sunrgbd
|
|
ZwwWayne
approved these changes
Jan 1, 2021
ZwwWayne
approved these changes
Jan 19, 2021
|
Thanks for the kind contribution. |
tpoisonooo
pushed a commit
to tpoisonooo/mmdetection3d
that referenced
this pull request
Sep 5, 2022
* support yolov3 ncnn with Yolov3DetectionOutput * update nms * fix contiguous in ncnn wrapper * remove padding to detectionoutput * format cpp * Revert "format cpp" This reverts commit 54050b19cd80d2f8cd851d82a755fd2c8d6c779d. * fix zero detection * fix yapf * onnx2ncnn.cpp * fix ut * fix isort * fix clang-format * format cpp * resolve comments * resolve comments * fix ut of ncnnend2endmodel * fix yapf * fix return list; Co-authored-by: hanrui1sensetime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the VoteNet demo on sunrgbd with:
I got an error in
mmdetection3d/mmdet3d/ops/furthest_point_sample/furthest_point_sample.pybecausepoints_xyzwas a tuple of size 4, but it was being unpacked into a tuple of size 3. I changed:to
and now everything works correctly.