Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Fix init in cam_box3d #148

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

Tai-Wang
Copy link
Member

@Tai-Wang Tai-Wang commented Oct 6, 2020

The cam_box3d's inherited init in base_box3d uses a different default origin. This PR fixes this minor bug.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #148 into master will decrease coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   50.07%   50.06%   -0.02%     
==========================================
  Files         164      164              
  Lines       10648    10669      +21     
  Branches     1615     1619       +4     
==========================================
+ Hits         5332     5341       +9     
- Misses       4994     5003       +9     
- Partials      322      325       +3     
Flag Coverage Δ
#unittests 50.06% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/bbox/structures/cam_box3d.py 72.07% <42.85%> (-6.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edebb3e...658c071. Read the comment docs.

@Tai-Wang Tai-Wang changed the title Fix init in cam_box3d [Fix]: Fix init in cam_box3d Oct 6, 2020
@ZwwWayne ZwwWayne merged commit 733df01 into open-mmlab:master Oct 7, 2020
@ZwwWayne ZwwWayne mentioned this pull request Oct 11, 2020
@Tai-Wang Tai-Wang deleted the fix_cam_box3d branch October 31, 2020 13:29
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022
* Fix include and lib paths for onnxruntime.

* Fixes for SSD export test

* Add onnx2openvino and OpenVINODetector. Test models: ssd, retinanet, fcos, fsaf.

* Add support for two-stage models: faster_rcnn, cascade_rcnn

* Add doc

* Add strip_doc_string for openvino.

* Fix openvino preprocess.

* Add OpenVINO to test_wrapper.py.

* Fix

* Add openvino_execute.

* Removed preprocessing.

* Fix onnxruntime cmake.

* Rewrote postprocessing and forward, added docstrings and fixes.

* Added device type change to OpenVINOWrapper.

* Update forward_of_single_roi_extractor_dynamic_openvino and fix doc.

* Update docs.

* Add support for masks (Mask RCNN).

* Add masks to CascadeRoIHead.simple_test.

* Added masks to test_OpenVINODetector.

* Added test_cascade_roi_head_with_mask.

* Update docs.

* Fix segm_results shape.

* Fix TopK in NMS and add test_multiclass_nms_with_keep_top_k.

* Removed unnecessary functions.

* Fix.

* Fix test_multiclass_nms_with_keep_top_k.

* Updated test_OpenVINODetector.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants