Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs of BackgroundPointsFilter #347

Closed
meng-zha opened this issue Mar 9, 2021 · 2 comments · Fixed by #609
Closed

Bugs of BackgroundPointsFilter #347

meng-zha opened this issue Mar 9, 2021 · 2 comments · Fixed by #609
Assignees
@xiliu8006

Comments

@meng-zha
Copy link
Contributor

meng-zha commented Mar 9, 2021

BackgroundPointsFilter transformer changes the LiDARInstance3DBox's tensor to the gravity center while it should be the bottom_center. The box_np_ops.points_in_rbbox deals with the boxes of bottom center as well. So there may be some bugs here.
@meng-zha
Copy link
Contributor Author

meng-zha commented Mar 9, 2021

And I also want to know why the enlarged_gt_bboxes_3d here minus the expand_dims_length while this has been done in the LiDARInstance3DBox.enlarged_box.

@meng-zha
Copy link
Contributor Author

@encore-zhou

@xiliu8006 xiliu8006 mentioned this issue Jun 1, 2021
Merged
@xiliu8006 xiliu8006 linked a pull request Jun 1, 2021 that will close this issue
[Fix] Fix bg point filter #609
Merged
tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this issue Sep 5, 2022
@grimoire @PeterH0323
[Refactor][tools] Add prebuild tools. (open-mmlab#347)
4710ab9 
* move to lib

* optional import pytorch rewriter

* reduce torch dependancy of tensorrt export

* remove more mmcv support

* fix pytest

* remove mmcv logge

* Add `mmdeploy.utils.logging`

* Improve the common of the `get_logger`

* Fix lint

* onnxruntim add try catch to  import wrapper if pytorch is available

* Using `mmcv.utils.logging` in all files under `mmdeploy/codebase`

* add __init__

* add prebuild tools

* support windows

* for comment

* exit if failed

* add exist

* decouple

* add tags

* remove .mmdeploy_python

* read python version from system

* update windows config

* update linux config

* remote many

* better build name

* rename python tag

* fix pyhon-tag

* update window config

* add env search

* update tag

* fix build without CUDA_TOOLKIT_ROOT_DIR

Co-authored-by: HinGwenWoong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiliu8006 xiliu8006

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Fix bg point filter xiliu8006/mmdetection3d
3 participants
@encore-zhou @meng-zha @xiliu8006