Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Limit mmpose requirement #440

Merged
merged 1 commit into from
May 7, 2022
Merged

Conversation

grimoire
Copy link
Member

@grimoire grimoire commented May 7, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The requirements of MMPose conflict with OpenVINO.

Modification

mmpose>=0.24.0,<=0.25.1

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #440 (5cd6d08) into dev-v0.5.0 (2265217) will decrease coverage by 0.01%.
The diff coverage is 63.04%.

@@              Coverage Diff               @@
##           dev-v0.5.0     #440      +/-   ##
==============================================
- Coverage       62.62%   62.60%   -0.02%     
==============================================
  Files             219      220       +1     
  Lines            7291     7312      +21     
  Branches         1120     1126       +6     
==============================================
+ Hits             4566     4578      +12     
- Misses           2402     2410       +8     
- Partials          323      324       +1     
Flag Coverage Δ
unittests 62.60% <63.04%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/codebase/base/backend_model.py 46.93% <0.00%> (-3.07%) ⬇️
...odebase/mmdet/models/roi_heads/cascade_roi_head.py 100.00% <ø> (ø)
mmdeploy/pytorch/ops/__init__.py 100.00% <ø> (ø)
mmdeploy/pytorch/functions/chunk.py 25.00% <25.00%> (ø)
...oy/codebase/mmdet/core/post_processing/bbox_nms.py 46.61% <50.00%> (ø)
mmdeploy/codebase/mmdet/deploy/utils.py 86.20% <100.00%> (-0.89%) ⬇️
...debase/mmdet/models/dense_heads/base_dense_head.py 32.64% <100.00%> (+0.35%) ⬆️
...ploy/codebase/mmdet/models/dense_heads/gfl_head.py 63.91% <100.00%> (+0.37%) ⬆️
...ploy/codebase/mmdet/models/dense_heads/rpn_head.py 49.13% <100.00%> (+0.44%) ⬆️
...loy/codebase/mmdet/models/dense_heads/yolo_head.py 70.96% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f6e25...5cd6d08. Read the comment docs.

@grimoire grimoire requested a review from lvhan028 May 7, 2022 08:16
@lvhan028 lvhan028 merged commit 81a9719 into open-mmlab:dev-v0.5.0 May 7, 2022
@grimoire grimoire deleted the fix-ci branch June 23, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants