[Refactor][tools] Add prebuild tools. #347

grimoire · 2022-04-14T03:33:17Z

This PR provides tools to build prebuilt tools. Some other files are also modified to support the pre-build packaging.
Has been tested on linux-x64, both PC and jetson. TesnorRT on both platform and ONNXRuntime on PC.
Usage:

python ${MMDEPLOY_DIR}/tools/package_tools/mmdeploy_builder.py \
    ${MMDEPLOY_DIR}/tools/package_tools/configs/linux_x86_trt.yaml \
    ${MMDEPLOY_DIR}

You might need to edit your own config file to build a different package.
Windows package can also be built, but it has not been tested.

codecov · 2022-04-15T04:10:03Z

Codecov Report

Merging #347 (f00fe81) into dev-v0.5.0 (81a9719) will increase coverage by 3.29%.
The diff coverage is 33.33%.

❗ Current head f00fe81 differs from pull request most recent head 2edc101. Consider uploading reports for the commit 2edc101 to get more accurate results

@@              Coverage Diff               @@
##           dev-v0.5.0     #347      +/-   ##
==============================================
+ Coverage       59.18%   62.47%   +3.29%     
==============================================
  Files             233      221      -12     
  Lines            7739     7366     -373     
  Branches         1186     1136      -50     
==============================================
+ Hits             4580     4602      +22     
+ Misses           2835     2434     -401     
- Partials          324      330       +6

Flag	Coverage Δ
unittests	`62.47% <33.33%> (+3.29%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdeploy/backend/ncnn/__init__.py	`47.05% <0.00%> (-10.09%)`	⬇️
mmdeploy/backend/onnxruntime/init_plugins.py	`100.00% <ø> (ø)`
mmdeploy/backend/tensorrt/calib_utils.py	`0.00% <0.00%> (ø)`
mmdeploy/backend/tensorrt/init_plugins.py	`31.25% <ø> (ø)`
mmdeploy/backend/tensorrt/utils.py	`0.00% <0.00%> (ø)`
mmdeploy/backend/tensorrt/wrapper.py	`0.00% <0.00%> (ø)`
mmdeploy/backend/sdk/__init__.py	`55.00% <14.28%> (-3.83%)`	⬇️
mmdeploy/backend/tensorrt/__init__.py	`37.50% <16.66%> (-16.35%)`	⬇️
mmdeploy/__init__.py	`45.45% <25.00%> (-17.05%)`	⬇️
mmdeploy/backend/__init__.py	`44.44% <28.57%> (+0.44%)`	⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f59b44...2edc101. Read the comment docs.

grimoire · 2022-04-21T08:30:24Z

Remove dependency in mmdeploy/codebase is not necessary. Since all these codebase reqire MMCV.

grimoire · 2022-05-02T08:46:45Z

Note that new api might require some features from this PR.

RunningLeon · 2022-05-05T03:42:38Z

mmdeploy/backend/tensorrt/utils.py

+    import os
+    old_cuda_device = os.environ.get('CUDA_DEVICE', None)
+    os.environ['CUDA_DEVICE'] = str(device_id)
+    import pycuda.autoinit  # noqa:F401


we may add pycuda to requirements

And I tested on Jetson, I only install successful with pycuda==2019.1. I haven't look up why yet.
I suggest we do not using lastest version of pycuda, we can set it to 2019.1

Found that pycuda has been released not so often. Have you tried version of 2021.1?

grimoire · 2022-05-05T09:11:36Z

The builder has been moved here.

RunningLeon · 2022-05-16T10:22:47Z

Tested fine with trt in my linux.

Me too.

lvhan028 · 2022-05-16T12:18:50Z

Have you had any idea about the package naming rules?

Nope. Should we use different package names for the different backend?

I am afraid the package will explode if we put backend as a part of the package name.
Here is my proposal:
mmdeploy-{os tag}-{cpu arch}-{device}?-version.{file extension}
e.g.,

mmdeploy-linux-x86_64-gpu-0.5.0.tar.gz
mmdeploy-windows-x86_64-0.5.0.zip

lvhan028 · 2022-05-17T03:54:16Z

Mode	LastWriteTime	Length Name
d-----	5/17/2022	11:48 AM	.mmdeploy_python
d-----	5/17/2022	11:48 AM	dist
d-----	5/17/2022	11:48 AM	sdk

In windows, after running the prebuild scripts, a .mmdeploy_python is generated. Is it necessary? What is it used for?

grimoire · 2022-05-17T06:46:33Z

Mode LastWriteTime Length Name
d----- 5/17/2022 11:48 AM .mmdeploy_python
d----- 5/17/2022 11:48 AM dist
d----- 5/17/2022 11:48 AM sdk
In windows, after running the prebuild scripts, a .mmdeploy_python is generated. Is it necessary? What is it used for?

It is a copy of tools/package_tools/packaging. We need these codes to build mmdeploy_python wheel.
Should I remove it after packaging?

tools/package_tools/configs/windows_ort.yaml

lvhan028 · 2022-05-18T06:17:35Z

Mode LastWriteTime Length Name
d----- 5/17/2022 11:48 AM .mmdeploy_python
d----- 5/17/2022 11:48 AM dist
d----- 5/17/2022 11:48 AM sdk
In windows, after running the prebuild scripts, a .mmdeploy_python is generated. Is it necessary? What is it used for?

It is a copy of tools/package_tools/packaging. We need these codes to build mmdeploy_python wheel. Should I remove it after packaging?

If they are not necessary for our users, I think we can remove it safely.

tools/package_tools/configs/jetson.yaml

tools/package_tools/mmdeploy_builder.py

* move to lib * optional import pytorch rewriter * reduce torch dependancy of tensorrt export * remove more mmcv support * fix pytest * remove mmcv logge * Add `mmdeploy.utils.logging` * Improve the common of the `get_logger` * Fix lint * onnxruntim add try catch to import wrapper if pytorch is available * Using `mmcv.utils.logging` in all files under `mmdeploy/codebase` * add __init__ * add prebuild tools * support windows * for comment * exit if failed * add exist * decouple * add tags * remove .mmdeploy_python * read python version from system * update windows config * update linux config * remote many * better build name * rename python tag * fix pyhon-tag * update window config * add env search * update tag * fix build without CUDA_TOOLKIT_ROOT_DIR Co-authored-by: HinGwenWoong <[email protected]>

grimoire mentioned this pull request Apr 15, 2022

Reduce torch dependency #273

Closed

lvhan028 mentioned this pull request Apr 29, 2022

build docker image error from Dockerfile #420

Closed

grimoire changed the title ~~[WIP]fix for pre-build~~ [Refactor] fix for pre-build May 2, 2022

grimoire changed the base branch from master to dev-v0.5.0 May 2, 2022 08:20

grimoire and others added 12 commits May 2, 2022 16:32

move to lib

da87a80

optional import pytorch rewriter

2a03ca7

reduce torch dependancy of tensorrt export

8047c1b

remove more mmcv support

93f2611

fix pytest

d90cd65

remove mmcv logge

4ec8e88

Add mmdeploy.utils.logging

3c8a85f

Improve the common of the get_logger

6f28158

Fix lint

3702378

onnxruntim add try catch to import wrapper if pytorch is available

b782773

Using mmcv.utils.logging in all files under mmdeploy/codebase

bb83390

add __init__

d70b803

grimoire force-pushed the fix-for-prebuilt branch from 8a7f236 to d70b803 Compare May 2, 2022 08:44

grimoire requested review from lvhan028, RunningLeon and AllentDan May 2, 2022 08:45

RunningLeon reviewed May 5, 2022

View reviewed changes

add prebuild tools

f00fe81

grimoire changed the title ~~[Refactor] fix for pre-build~~ [Refactor][tools] Add prebuild tools. May 5, 2022

grimoire requested a review from irexyc May 5, 2022 09:43

support windows

71521eb

PeterH0323 mentioned this pull request May 8, 2022

[WIP] Pre-build wheel test script #445

Closed

3 tasks

remove .mmdeploy_python

fa92dae

irexyc reviewed May 18, 2022

View reviewed changes

tools/package_tools/configs/windows_ort.yaml Outdated Show resolved Hide resolved

tools/package_tools/configs/windows_ort.yaml Outdated Show resolved Hide resolved

grimoire added 7 commits May 18, 2022 16:52

read python version from system

d616014

update windows config

31c9b10

update linux config

ace3b7d

remote many

4143279

better build name

f2e7b00

rename python tag

8eec447

fix pyhon-tag

5a59ab1

lvhan028 previously approved these changes May 21, 2022

View reviewed changes

update window config

a55b214

grimoire dismissed lvhan028’s stale review via a55b214 May 23, 2022 02:00

add env search

6e74153

grimoire requested review from lvhan028 and irexyc May 23, 2022 03:51

lvhan028 reviewed May 23, 2022

View reviewed changes

tools/package_tools/configs/jetson.yaml Outdated Show resolved Hide resolved

update tag

35d27bd

irexyc reviewed May 23, 2022

View reviewed changes

tools/package_tools/mmdeploy_builder.py Outdated Show resolved Hide resolved

fix build without CUDA_TOOLKIT_ROOT_DIR

2edc101

irexyc self-requested a review May 23, 2022 09:11

irexyc approved these changes May 23, 2022

View reviewed changes

lvhan028 approved these changes May 23, 2022

View reviewed changes

lvhan028 merged commit 4710ab9 into open-mmlab:dev-v0.5.0 May 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactor][tools] Add prebuild tools. #347

[Refactor][tools] Add prebuild tools. #347

grimoire commented Apr 14, 2022 •

edited

Loading

codecov bot commented Apr 15, 2022 •

edited

Loading

grimoire commented Apr 21, 2022

grimoire commented May 2, 2022

RunningLeon May 5, 2022

PeterH0323 May 5, 2022

RunningLeon May 5, 2022

grimoire commented May 5, 2022

RunningLeon commented May 16, 2022

lvhan028 commented May 16, 2022 •

edited

Loading

lvhan028 commented May 17, 2022

grimoire commented May 17, 2022 •

edited

Loading

lvhan028 commented May 18, 2022

[Refactor][tools] Add prebuild tools. #347

[Refactor][tools] Add prebuild tools. #347

Conversation

grimoire commented Apr 14, 2022 • edited Loading

codecov bot commented Apr 15, 2022 • edited Loading

Codecov Report

grimoire commented Apr 21, 2022

grimoire commented May 2, 2022

RunningLeon May 5, 2022

Choose a reason for hiding this comment

PeterH0323 May 5, 2022

Choose a reason for hiding this comment

RunningLeon May 5, 2022

Choose a reason for hiding this comment

grimoire commented May 5, 2022

RunningLeon commented May 16, 2022

lvhan028 commented May 16, 2022 • edited Loading

lvhan028 commented May 17, 2022

grimoire commented May 17, 2022 • edited Loading

lvhan028 commented May 18, 2022

grimoire commented Apr 14, 2022 •

edited

Loading

codecov bot commented Apr 15, 2022 •

edited

Loading

lvhan028 commented May 16, 2022 •

edited

Loading

grimoire commented May 17, 2022 •

edited

Loading