Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add roi_align_rotated onnxruntime op #277

Merged
merged 14 commits into from
Apr 26, 2022

Conversation

zytx121
Copy link
Contributor

@zytx121 zytx121 commented Mar 26, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add roi_align_rotated onnxruntime op.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@grimoire grimoire mentioned this pull request Apr 1, 2022
@grimoire grimoire self-requested a review April 1, 2022 10:59
@grimoire
Copy link
Member

grimoire commented Apr 2, 2022

Please merge latest master branch and fix the lint.

@zytx121
Copy link
Contributor Author

zytx121 commented Apr 13, 2022

Please merge latest master branch and fix the lint.

Done.

@grimoire
Copy link
Member

You can just ignore the circleci error failing for now.

@zytx121
Copy link
Contributor Author

zytx121 commented Apr 14, 2022

You can just ignore the circleci error failing for now.

OK

@grimoire grimoire requested a review from irexyc April 14, 2022 08:14
grimoire
grimoire previously approved these changes Apr 14, 2022
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irexyc
irexyc previously approved these changes Apr 18, 2022
@grimoire grimoire changed the base branch from master to dev-v0.5.0 April 18, 2022 09:10
@grimoire grimoire dismissed stale reviews from irexyc and themself April 18, 2022 09:10

The base branch was changed.

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #277 (526cf83) into dev-v0.5.0 (9411fe0) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@              Coverage Diff               @@
##           dev-v0.5.0     #277      +/-   ##
==============================================
+ Coverage       62.84%   62.86%   +0.02%     
==============================================
  Files             213      214       +1     
  Lines            7189     7196       +7     
  Branches         1109     1109              
==============================================
+ Hits             4518     4524       +6     
- Misses           2348     2349       +1     
  Partials          323      323              
Flag Coverage Δ
unittests 62.86% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/mmcv/ops/roi_align_rotated.py 83.33% <83.33%> (ø)
mmdeploy/mmcv/ops/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9411fe0...526cf83. Read the comment docs.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 01a44c0 into open-mmlab:dev-v0.5.0 Apr 26, 2022
lvhan028 pushed a commit to lvhan028/mmdeploy that referenced this pull request Jun 3, 2022
* init

* add doc

* add

* Update test_ops.py

* fix bug

* fix pose demo and windows build (open-mmlab#307)

* add postprocessing_masks gpu version (open-mmlab#276)

* add postprocessing_masks gpu version

* default device cpu

* pre-commit fix

Co-authored-by: hadoop-basecv <[email protected]>

* fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310)

* [Fix] include missing <type_traits> for formatter.h (open-mmlab#313)

* fix formatter

* relax GCC version requirement

* fix lint

* Update onnxruntime.md

* fix lint

Co-authored-by: Chen Xin <[email protected]>
Co-authored-by: Shengxi Li <[email protected]>
Co-authored-by: hadoop-basecv <[email protected]>
Co-authored-by: lzhangzz <[email protected]>
lvhan028 pushed a commit to lvhan028/mmdeploy that referenced this pull request Jun 3, 2022
* init

* add doc

* add

* Update test_ops.py

* fix bug

* fix pose demo and windows build (open-mmlab#307)

* add postprocessing_masks gpu version (open-mmlab#276)

* add postprocessing_masks gpu version

* default device cpu

* pre-commit fix

Co-authored-by: hadoop-basecv <[email protected]>

* fixed a bug causes text-recognizer to fail when (non-NULL) empty bboxes list is passed (open-mmlab#310)

* [Fix] include missing <type_traits> for formatter.h (open-mmlab#313)

* fix formatter

* relax GCC version requirement

* fix lint

* Update onnxruntime.md

* fix lint

Co-authored-by: Chen Xin <[email protected]>
Co-authored-by: Shengxi Li <[email protected]>
Co-authored-by: hadoop-basecv <[email protected]>
Co-authored-by: lzhangzz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants