-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Optimize preprocess & fix pontential use-after-free #229
Conversation
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 66.83% 66.82% -0.02%
==========================================
Files 190 190
Lines 6292 6293 +1
Branches 981 981
==========================================
Hits 4205 4205
- Misses 1778 1779 +1
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please merge to master branch, and add |
# Conflicts: # csrc/preprocess/transform/pad.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Modification
Tensor
/Mat
if possible.Compose
BC-breaking (Optional)
None (hopefully)
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist