Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add 320x320 static config for tensorrt #1689

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[Enhancement] Add 320x320 static config for tensorrt #1689

merged 2 commits into from
Jan 31, 2023

Conversation

hanrui1sensetime
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

RTMDet needs 320x320 static config for tensorrt backend, so add this.

Modification

FP32, FP16, INT8 configs.

BC-breaking (Optional)

None.

Use cases (Optional)

None.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hanrui1sensetime hanrui1sensetime added the enhancement New feature or request label Jan 31, 2023
@hanrui1sensetime hanrui1sensetime changed the base branch from master to dev-1.x January 31, 2023 03:28
@lvhan028
Copy link
Collaborator

Can we only add configs in detection rather than base?

RunningLeon
RunningLeon approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lvhan028
lvhan028 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 2ceabd0 into open-mmlab:dev-1.x Jan 31, 2023
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
@hanrui1sensetime @lvhan028
[Enhancement] Add 320x320 static config for tensorrt (#1689)
0848795 
* add trt static 320 config for rtmdet

* only add on detection folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RunningLeon RunningLeon RunningLeon approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanrui1sensetime @lvhan028 @RunningLeon