Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Relax module adapter template constraints #1366

Merged
merged 2 commits into from
Nov 27, 2022

Conversation

lzhangzz
Copy link
Collaborator

Relax module adpater template constraints so that derived class does not have to forward operator() to base class.

Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

May remove

Result<Value> YOLOV3Head::operator()(const Value& prep_res, const Value& infer_res) {
  return YOLOHead::operator()(prep_res, infer_res);
}

and

Result<Value> YOLOV5Head::operator()(const Value& prep_res, const Value& infer_res) {
  return YOLOHead::operator()(prep_res, infer_res);
}

in yolo_head.cpp

@lzhangzz lzhangzz force-pushed the relax-module-adapter branch from 9ef79ed to 67632d1 Compare November 25, 2022 04:06
@lzhangzz
Copy link
Collaborator Author

May remove

Result<Value> YOLOV3Head::operator()(const Value& prep_res, const Value& infer_res) {
  return YOLOHead::operator()(prep_res, infer_res);
}

and

Result<Value> YOLOV5Head::operator()(const Value& prep_res, const Value& infer_res) {
  return YOLOHead::operator()(prep_res, infer_res);
}

in yolo_head.cpp

done

@lvhan028 lvhan028 merged commit 6468ef1 into open-mmlab:master Nov 27, 2022
triple-Mu pushed a commit to triple-Mu/mmdeploy that referenced this pull request Dec 5, 2022
* relax module adapter constraint

* remove forwarding `operator()`
irexyc pushed a commit to irexyc/mmdeploy that referenced this pull request Jan 11, 2023
* relax module adapter constraint

* remove forwarding `operator()`
irexyc pushed a commit to irexyc/mmdeploy that referenced this pull request Jan 11, 2023
* relax module adapter constraint

* remove forwarding `operator()`
irexyc pushed a commit to irexyc/mmdeploy that referenced this pull request Jan 16, 2023
* relax module adapter constraint

* remove forwarding `operator()`
lzhangzz added a commit that referenced this pull request Jan 17, 2023
…1.x (#1635)

* [Fix] Fix example standalone build for msvc (#1626)

* fix example build for msvc

* move /Zc:__cplusplus to core

* [FIX] Fix csharp net48 and batch inference (#1370)

* fix csharp net48

* add missing file

* update

* fix batch inference

* update demo

* update

* update version

* update nuget package version & fix project name

* build monolithic SDK by default (#1577)

* Fix debug build for PoseTracker (#1601)

* [Fix] Fix aligned allocations on Android (#1612)

* fix android alignment

* fix typo

* fix size

* Fix build error on windows-cuda platform (#1598)

* [Fix] Relax module adapter template constraints (#1366)

* relax module adapter constraint

* remove forwarding `operator()`

* fix YOLOV5Head naming

Co-authored-by: Li Zhang <[email protected]>
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
…1.x (#1635)

* [Fix] Fix example standalone build for msvc (#1626)

* fix example build for msvc

* move /Zc:__cplusplus to core

* [FIX] Fix csharp net48 and batch inference (#1370)

* fix csharp net48

* add missing file

* update

* fix batch inference

* update demo

* update

* update version

* update nuget package version & fix project name

* build monolithic SDK by default (#1577)

* Fix debug build for PoseTracker (#1601)

* [Fix] Fix aligned allocations on Android (#1612)

* fix android alignment

* fix typo

* fix size

* Fix build error on windows-cuda platform (#1598)

* [Fix] Relax module adapter template constraints (#1366)

* relax module adapter constraint

* remove forwarding `operator()`

* fix YOLOV5Head naming

Co-authored-by: Li Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants