-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Relax module adapter template constraints #1366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllentDan
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
May remove Result<Value> YOLOV3Head::operator()(const Value& prep_res, const Value& infer_res) {
return YOLOHead::operator()(prep_res, infer_res);
} and Result<Value> YOLOV5Head::operator()(const Value& prep_res, const Value& infer_res) {
return YOLOHead::operator()(prep_res, infer_res);
} in |
lzhangzz
force-pushed
the
relax-module-adapter
branch
from
November 25, 2022 04:06
9ef79ed
to
67632d1
Compare
done |
lvhan028
approved these changes
Nov 27, 2022
triple-Mu
pushed a commit
to triple-Mu/mmdeploy
that referenced
this pull request
Dec 5, 2022
* relax module adapter constraint * remove forwarding `operator()`
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 11, 2023
* relax module adapter constraint * remove forwarding `operator()`
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 11, 2023
* relax module adapter constraint * remove forwarding `operator()`
irexyc
pushed a commit
to irexyc/mmdeploy
that referenced
this pull request
Jan 16, 2023
* relax module adapter constraint * remove forwarding `operator()`
lzhangzz
added a commit
that referenced
this pull request
Jan 17, 2023
…1.x (#1635) * [Fix] Fix example standalone build for msvc (#1626) * fix example build for msvc * move /Zc:__cplusplus to core * [FIX] Fix csharp net48 and batch inference (#1370) * fix csharp net48 * add missing file * update * fix batch inference * update demo * update * update version * update nuget package version & fix project name * build monolithic SDK by default (#1577) * Fix debug build for PoseTracker (#1601) * [Fix] Fix aligned allocations on Android (#1612) * fix android alignment * fix typo * fix size * Fix build error on windows-cuda platform (#1598) * [Fix] Relax module adapter template constraints (#1366) * relax module adapter constraint * remove forwarding `operator()` * fix YOLOV5Head naming Co-authored-by: Li Zhang <[email protected]>
lvhan028
pushed a commit
that referenced
this pull request
Mar 1, 2023
…1.x (#1635) * [Fix] Fix example standalone build for msvc (#1626) * fix example build for msvc * move /Zc:__cplusplus to core * [FIX] Fix csharp net48 and batch inference (#1370) * fix csharp net48 * add missing file * update * fix batch inference * update demo * update * update version * update nuget package version & fix project name * build monolithic SDK by default (#1577) * Fix debug build for PoseTracker (#1601) * [Fix] Fix aligned allocations on Android (#1612) * fix android alignment * fix typo * fix size * Fix build error on windows-cuda platform (#1598) * [Fix] Relax module adapter template constraints (#1366) * relax module adapter constraint * remove forwarding `operator()` * fix YOLOV5Head naming Co-authored-by: Li Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax module adpater template constraints so that derived class does not have to forward
operator()
to base class.