Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tensorrt test failed with pytorch 1.8+ #1464

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

twmht
Copy link
Contributor

@twmht twmht commented Nov 6, 2021

Motivation

this PR resolves #1454

thanks the help from @grimoire

Modification

add -Xcompiler=-fno-gnu-unique in nvcc

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2021

CLA assistant check
All committers have signed the CLA.

@zhouzaida zhouzaida requested a review from grimoire November 7, 2021 09:44
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM

@twmht
Copy link
Contributor Author

twmht commented Nov 21, 2021

@grimoire

Do I need to rerun the workflow? it seems that one of the failed ci is not related to this patch.

@zhouzaida
Copy link
Collaborator

@grimoire

Do I need to rerun the workflow? it seems that one of the failed ci is not related to this patch.

Yet, I re-run it now.

@zhouzaida zhouzaida self-requested a review December 1, 2021 15:17
setup.py Show resolved Hide resolved
@twmht
Copy link
Contributor Author

twmht commented Dec 7, 2021

@grimoire and @zhouzaida

thanks for your help.

@zhouzaida
Copy link
Collaborator

@grimoire and @zhouzaida

thanks for your help.

Thanks for your contribution and welcome to the OpenMMLab community.

@zhouzaida zhouzaida requested a review from ZwwWayne December 7, 2021 15:48
@ZwwWayne ZwwWayne merged commit 48f44b6 into open-mmlab:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensorrt test failed
5 participants