[Feature] Support custom hooks in IterBasedRunner.
#1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzr1996
changed the title
IterBasedRunner.
Codecov Report
@@ Coverage Diff @@
## master #1193 +/- ##
==========================================
+ Coverage 67.97% 68.01% +0.03%
==========================================
Files 159 159
Lines 10434 10429 -5
Branches 1899 1899
==========================================
Hits 7093 7093
+ Misses 2970 2965 -5
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
mzr1996
force-pushed
the
iter_custom_hook
branch
from
d554087 to
f39371b
Compare
ZwwWayne
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IterBasedRunnerdoesn't support custom hooks by now.Modification
Support custom hooks in
IterBasedRunner.BC-breaking (Optional)
No
Use cases (Optional)
Refers to #1120