Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variables in base files for configs #1083

Merged
merged 11 commits into from
Jun 25, 2021

Conversation

innerlee
Copy link
Contributor

@innerlee innerlee commented Jun 7, 2021

You can reference variables in base files now. See the test file for examples.

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #1083 (5a41a39) into master (eb08835) will increase coverage by 0.10%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   67.74%   67.84%   +0.10%     
==========================================
  Files         159      159              
  Lines       10337    10376      +39     
  Branches     1873     1885      +12     
==========================================
+ Hits         7003     7040      +37     
- Misses       2966     2967       +1     
- Partials      368      369       +1     
Flag Coverage Δ
unittests 67.84% <94.87%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/utils/config.py 90.38% <94.87%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb08835...5a41a39. Read the comment docs.

innerlee added 7 commits June 7, 2021 13:52
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
@innerlee
Copy link
Contributor Author

innerlee commented Jun 9, 2021

Open for discussion: should we use {{ base.xxx }} or {{ _base_.xxx }}

Benefit of base: clean, short.
Benefit of _base_: can pass flake8.

@ZwwWayne
Copy link
Collaborator

ZwwWayne commented Jun 14, 2021

Open for discussion: should we use {{ base.xxx }} or {{ _base_.xxx }}

Benefit of base: clean, short.
Benefit of _base: can pass flake8.

suggest using _base_ to keep consistency with that in the file header.

@ZwwWayne ZwwWayne mentioned this pull request Jun 14, 2021
8 tasks
@innerlee
Copy link
Contributor Author

@ZwwWayne pls check the comment to see if the _ was used as emph in markdown

@innerlee
Copy link
Contributor Author

Another "pro" for base is that we can extend the gramma to "env"

@ZwwWayne
Copy link
Collaborator

@ZwwWayne pls check the comment to see if the _ was used as emph in markdown

should be _base_

@zhouzaida zhouzaida mentioned this pull request Jun 21, 2021
13 tasks
@ZwwWayne
Copy link
Collaborator

Need to resolve confilcts.

@innerlee
Copy link
Contributor Author

ping @ZwwWayne ~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants