-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variables in base files for configs #1083
Conversation
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
+ Coverage 67.74% 67.84% +0.10%
==========================================
Files 159 159
Lines 10337 10376 +39
Branches 1873 1885 +12
==========================================
+ Hits 7003 7040 +37
- Misses 2966 2967 +1
- Partials 368 369 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Signed-off-by: lizz <[email protected]>
Open for discussion: should we use Benefit of |
suggest using |
@ZwwWayne pls check the comment to see if the _ was used as emph in markdown |
Another "pro" for base is that we can extend the gramma to "env" |
should be |
Signed-off-by: lizz <[email protected]>
Need to resolve confilcts. |
ping @ZwwWayne ~~ |
You can reference variables in base files now. See the test file for examples.