Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ms_deformable_attn in parrots #1042

Merged

Conversation

luopeichao
Copy link
Contributor

Modification

  • Add ms_deformable_attn support in parrots.
  • Modify parrots ext_module loading strategy. Now you will get a fake function if the function you try to load is not implemented in parrots, and the fake function can raise exception when you call it.

@zhouzaida zhouzaida mentioned this pull request May 21, 2021
9 tasks
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #1042 (d224841) into master (1a66977) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head d224841 differs from pull request most recent head 5b16b5b. Consider uploading reports for the commit 5b16b5b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   65.32%   65.35%   +0.02%     
==========================================
  Files         154      156       +2     
  Lines        9895     9984      +89     
  Branches     1801     1813      +12     
==========================================
+ Hits         6464     6525      +61     
- Misses       3100     3122      +22     
- Partials      331      337       +6     
Flag Coverage Δ
unittests 65.35% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/multi_scale_deform_attn.py 69.69% <0.00%> (-6.97%) ⬇️
mmcv/utils/ext_loader.py 38.23% <0.00%> (-13.77%) ⬇️
mmcv/ops/modulated_deform_conv.py 49.56% <0.00%> (-0.88%) ⬇️
mmcv/cnn/utils/weight_init.py 91.15% <0.00%> (-0.75%) ⬇️
mmcv/cnn/__init__.py 100.00% <0.00%> (ø)
mmcv/cnn/utils/__init__.py 100.00% <0.00%> (ø)
mmcv/runner/hooks/__init__.py 100.00% <0.00%> (ø)
mmcv/runner/hooks/logger/__init__.py 100.00% <0.00%> (ø)
mmcv/cnn/bricks/generalized_attention.py 92.81% <0.00%> (ø)
mmcv/commit_id.py 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a66977...5b16b5b. Read the comment docs.

@luopeichao luopeichao force-pushed the pc/parrots_ms_deformable_attn branch from 9575e46 to bec2e15 Compare May 21, 2021 10:54
@ZwwWayne
Copy link
Collaborator

PR can be merged after fixing lint issues.

@luopeichao luopeichao force-pushed the pc/parrots_ms_deformable_attn branch from d224841 to 2ffd006 Compare May 23, 2021 16:54
@luopeichao luopeichao force-pushed the pc/parrots_ms_deformable_attn branch from 2ffd006 to 5b16b5b Compare May 23, 2021 17:03
@ZwwWayne ZwwWayne merged commit 732ff50 into open-mmlab:master May 25, 2021
@luopeichao luopeichao deleted the pc/parrots_ms_deformable_attn branch January 11, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants