Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: add TensorRT InstanceNormalization plugin #1034

Merged
merged 5 commits into from
May 25, 2021
Merged

[Feature]: add TensorRT InstanceNormalization plugin #1034

merged 5 commits into from
May 25, 2021

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented May 19, 2021 •
edited
Loading

This PR includes:

  • Add InstanceNormalization plugin that supports dynamic shape in TensorRT.
  • Update relevant docs.

@RunningLeon RunningLeon requested a review from grimoire May 19, 2021 11:12
@RunningLeon RunningLeon self-assigned this May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021 •
edited
Loading

Codecov Report

Merging #1034 (bb933a6) into master (13888df) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
- Coverage   65.38%   65.37%   -0.02%     
==========================================
  Files         156      156              
  Lines        9981     9983       +2     
  Branches     1815     1816       +1     
==========================================
  Hits         6526     6526              
- Misses       3118     3120       +2     
  Partials      337      337
Flag Coverage Δ
unittests 65.37% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/tensorrt/tensorrt_utils.py 2.38% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13888df...bb933a6. Read the comment docs.

grimoire
grimoire reviewed May 20, 2021
View reviewed changes
mmcv/ops/csrc/tensorrt/plugins/trt_instance_norm.cpp Outdated Show resolved Hide resolved
mmcv/ops/csrc/tensorrt/trt_instance_norm.hpp Outdated Show resolved Hide resolved
tests/test_ops/test_tensorrt.py Outdated Show resolved Hide resolved
tests/test_ops/test_tensorrt.py Outdated Show resolved Hide resolved
grimoire
grimoire approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RunningLeon RunningLeon mentioned this pull request May 21, 2021
Merged
4 tasks
@RunningLeon RunningLeon requested a review from ZwwWayne May 25, 2021 03:20
@RunningLeon RunningLeon requested a review from ZwwWayne May 25, 2021 05:53
@ZwwWayne ZwwWayne merged commit 4d42365 into open-mmlab:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZwwWayne ZwwWayne ZwwWayne approved these changes

@grimoire grimoire grimoire approved these changes

Assignees

@RunningLeon RunningLeon

Labels
Deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RunningLeon @grimoire @ZwwWayne