Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add windows CI #1023

Merged
merged 24 commits into from
Aug 24, 2021
Merged

[Feature] Add windows CI #1023

merged 24 commits into from
Aug 24, 2021

Conversation

ZwwWayne
Copy link
Collaborator

Add Windows CI in GitHub actions.

@ZwwWayne ZwwWayne added the WIP label May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1023 (010f398) into master (db580dd) will increase coverage by 0.43%.
The diff coverage is 64.28%.

❗ Current head 010f398 differs from pull request most recent head 0a98e15. Consider uploading reports for the commit 0a98e15 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   67.99%   68.43%   +0.43%     
==========================================
  Files         159      160       +1     
  Lines       10426    10612     +186     
  Branches     1897     1939      +42     
==========================================
+ Hits         7089     7262     +173     
- Misses       2968     2975       +7     
- Partials      369      375       +6     
Flag Coverage Δ
unittests 68.43% <64.28%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/__init__.py 100.00% <ø> (ø)
mmcv/arraymisc/__init__.py 100.00% <ø> (ø)
mmcv/arraymisc/quantization.py 100.00% <ø> (ø)
mmcv/cnn/__init__.py 100.00% <ø> (ø)
mmcv/cnn/alexnet.py 26.08% <ø> (ø)
mmcv/cnn/bricks/__init__.py 100.00% <ø> (ø)
mmcv/cnn/bricks/context_block.py 96.96% <ø> (ø)
mmcv/cnn/bricks/conv.py 100.00% <ø> (ø)
mmcv/cnn/bricks/conv2d_adaptive_padding.py 94.73% <ø> (ø)
mmcv/cnn/bricks/conv_module.py 100.00% <ø> (ø)
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db580dd...0a98e15. Read the comment docs.

@ZwwWayne ZwwWayne mentioned this pull request May 14, 2021
9 tasks
@zhouzaida zhouzaida mentioned this pull request May 26, 2021
11 tasks
@ZwwWayne ZwwWayne mentioned this pull request Jun 14, 2021
8 tasks
@zhouzaida zhouzaida mentioned this pull request Jun 21, 2021
13 tasks
@ZwwWayne ZwwWayne mentioned this pull request Jun 27, 2021
20 tasks
@fcakyon
Copy link
Contributor

fcakyon commented Jul 1, 2021

@ZwwWayne how is this pr going? is it related with prebuilt binaries for windows?

@zhouzaida zhouzaida mentioned this pull request Jul 10, 2021
12 tasks
@zhouzaida zhouzaida mentioned this pull request Jul 26, 2021
18 tasks
@zhouzaida zhouzaida mentioned this pull request Aug 13, 2021
13 tasks
@ZwwWayne
Copy link
Collaborator Author

@ZwwWayne how is this pr going? is it related with prebuilt binaries for windows?

Yes, we plan to merge it in the next release. The next step is to release prebuilt binaries for windows.

@ZwwWayne
Copy link
Collaborator Author

LGTM, invite @innerlee to have a look.

@ZwwWayne ZwwWayne requested a review from innerlee August 21, 2021 03:21
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
mmcv/runner/hooks/logger/pavi.py Show resolved Hide resolved
@ZwwWayne ZwwWayne merged commit 979a355 into open-mmlab:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants