Add Debatts Some Code #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Who Can Review? |
yuantuo666
requested changes
Oct 28, 2024
models/tts/debatts/t2s_model_new.py
Outdated
| @torch.no_grad() | ||
| def sample_hf( | ||
| self, | ||
| phone_ids, # the phones of prompt and target should be concatenated together。在实际使用中，phone_ids是文本的token输入 |
There was a problem hiding this comment.
It's better to use English comments in the code. It's the same for other files.
models/tts/debatts/utils/tool.py
Outdated
models/tts/debatts/utils/logger.py
Outdated
HeCheng0625
reviewed
Oct 28, 2024
models/tts/debatts/environment.yml
Outdated
There was a problem hiding this comment.
Please use a simple env.sh file, you can follow https://github.com/open-mmlab/Amphion/blob/main/models/tts/maskgct/env.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
[Please describe the background, purpose, changes made, and how to test this PR]
🚧 Related Issues
[List the issue numbers related to this PR]
👨💻 Changes Proposed
🧑🤝🧑 Who Can Review?
[Please use the '@' symbol to mention any community member who is free to review the PR once the tests have passed. Feel free to tag members or contributors who might be interested in your PR.]
🛠 TODO
✅ Checklist