Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data padding to 'forward', 'inference', and 'get_prosody_featur… #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

norabai
Copy link

@norabai norabai commented Apr 20, 2024

Fix Issue #188

✨ Description

This PR adds data padding functionality to the forward, inference, and get_prosody_feature methods in our model class. The _pad_data function pads the input audio tensor, making sure that its last dimension is a multiple of the hop length. This is common in audio processing where all frames need to have equal lengths for certain computations or analyses.

To test this PR, run any processes that use the forward, inference, and get_prosody_feature methods and observe if there are any issues or improvements with how the processed audio data aligns with the hop length.

🚧 Related Issues

👨‍💻 Changes Proposed

  • Added _pad_data method which pads an input tensor along its last dimension.
  • Modified forward, inference, and get_prosody_feature methods to use _pad_data.

🧑‍🤝‍🧑 Who Can Review?

🛠 TODO

✅ Checklist

  • Code has been reviewed
  • Code complies with the project's code standards and best practices
  • Code has passed all tests
  • Code does not affect the normal use of existing features
  • Code has been commented properly
  • Documentation has been updated (if applicable)
  • Demo/checkpoint has been attached (if applicable)

@RMSnow RMSnow requested a review from HeCheng0625 April 25, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant