-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows compatibility #136
base: main
Are you sure you want to change the base?
Conversation
So now it can be executed on windows
NOTE: This is not final! Only things relevant to running combination of VALLE & libritts!
Hi @HighPriest, Thank you very much for submitting this valuable PR! Please don't hesitate to engage in further discussions with @RMSnow, @lmxue, and @VocodexElysium regarding any potential changes to this PR. |
Hi @HighPriest, thanks for your efforts! I reviewed your code. The design including replacing Amphion team has been actively exploring the best ways to support our Windows users. One viable approach is certainly the one you've proposed, which allows users to utilize their local windows machines to train a model from scratch. We are also considering alternative solutions such as that we only support basic education features such as visualization tools, Jupyter Notebook, interactive demo, and pretrained models for users. For those who want to utilize their local GPU, we provide only the tutorial of Linux-based virtual machine installation, and sill recommend them to use Linux platform to train neural networks. This is a challenging issue that touches on the core philosophy of our product, and we are yet to reach a definitive decision. We truly value your suggestions and efforts to enhance the functionality of Amphion. As an interim solution, we will recommend Windows users to leverage your branch in this PR as a patch. Thank you so much for your contribution! |
@RMSnow This PR has been marked as a draft! It doesn't complete the first step (features extraction), because of missing dependency on Windows. |
@HighPriest Oh, Sure! Thank you all the same :) |
π |
β¨ Description
As this is a Python application, there shouldn't be a reason for it to not be OS agnostic. Hence this PR.
π§ Related Issues
π¨βπ» Changes Proposed
π§βπ€βπ§ Who Can Review?
π TODO
Extracting phoneme sequence for libritts
)β Checklist