Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Day 1 service #19914

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Epic: Day 1 service #19914

wants to merge 62 commits into from

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Feb 21, 2025

Changes for https://github.com/open-metadata/openmetadata-collate/issues/1055
Changes for https://github.com/open-metadata/openmetadata-collate/issues/1054

I worked on adding the Insights tab on the service details page.

Screen.Recording.2025-03-05.at.3.07.12.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Feb 22, 2025

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.49% (42210/66484) 38.62% (16531/42806) 43.01% (5053/11748)

- Updated import for internationalization to use local i18next utility
- Removed direct import of 't' from 'i18next'
- Imported i18n from local utility and destructured 't' method
- Added Readonly type to ServiceInsightWidgetCommonProps prop interface
- Enhanced type safety for component props
chirag-madlani
chirag-madlani previously approved these changes Mar 6, 2025
Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, missed that

Copy link

sonarqubecloud bot commented Mar 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants