Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: highlight search text functionality #19405

Merged
merged 9 commits into from
Jan 30, 2025
Merged

feat: highlight search text functionality #19405

merged 9 commits into from
Jan 30, 2025

Conversation

pranita09
Copy link
Contributor

@pranita09 pranita09 commented Jan 16, 2025 •
edited
Loading

Describe your changes:

Fix #19441

Implemented the Highlight search text feature for the following pages:

  • Service Page for all Services
  • Database Services -> Databases -> Schemas and Ingestions
  • API Services -> Ingestions
  • Messaging Services -> Ingestions
  • Dashboard Services -> Ingestions
  • Pipeline Services -> Pipelines -> Executions & Ingestions
  • MLModel Services -> Ingestions
  • Storage Services -> Ingestions
  • Search Services -> Search Indexes -> Fields & Ingestions
  • Metadata Services -> Ingestions
  • Team & User Management -> Teams, Assets, Add Role, Add Policy
  • Bots
  • Domains -> Assets
Screen.Recording.2025-01-20.at.12.45.53.PM.mov
Screen.Recording.2025-01-20.at.12.47.31.PM.mov
Screen.Recording.2025-01-20.at.12.49.25.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@ShaileshParmar11 ShaileshParmar11 added the safe to test Add this label to run secure Github workflows on PRs label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.51% (41009/63572) 40.74% (16421/40311) 44.01% (4980/11316)

@pranita09 pranita09 changed the title WIP: highlight search text functionality feat: highlight search text functionality Jan 20, 2025
@pranita09 pranita09 marked this pull request as ready for review January 20, 2025 08:18
@pranita09 pranita09 requested a review from a team as a code owner January 20, 2025 08:18
ShaileshParmar11
ShaileshParmar11 reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

...ata-ui/src/main/resources/ui/src/components/Settings/Team/TeamDetails/TeamHierarchy.test.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/components/common/DisplayName/DisplayName.tsx Outdated Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/utils/IngestionListTableUtils.tsx Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pranita09 pranita09 merged commit 7afecdd into open-metadata:main Jan 30, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@Ashish8689 Ashish8689 Ashish8689 approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight Search Text Feature
3 participants
@pranita09 @Ashish8689 @ShaileshParmar11