Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Enhance Block Editor Adjust drag-and-drop handles and improve bar menu layout #19228

Merged
merged 10 commits into from
Jan 7, 2025
Merged

Minor: Enhance Block Editor Adjust drag-and-drop handles and improve bar menu layout #19228

merged 10 commits into from
Jan 7, 2025

Conversation

Sachin-chaurasiya
Copy link
Contributor

@Sachin-chaurasiya Sachin-chaurasiya commented Jan 3, 2025 •
edited
Loading

Describe your changes:

This PR includes the following changes

  • Remove Drag and Drop Handles
  • Improve the toolbar styling for small screen sizes
  • Improve the editor rendering in form
Screen.Recording.2025-01-07.at.12.19.41.PM.mov
Screen.Recording.2025-01-07.at.12.20.36.PM.mov

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.55% (40651/62973) 40.83% (16316/39959) 43.93% (4930/11223)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review January 7, 2025 07:22
@Sachin-chaurasiya Sachin-chaurasiya requested a review from a team as a code owner January 7, 2025 07:22
chirag-madlani
chirag-madlani previously approved these changes Jan 7, 2025
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
17.1% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani merged commit aceadb1 into main Jan 7, 2025
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the feat-#15380-patch-3 branch January 7, 2025 14:40
Sachin-chaurasiya added a commit that referenced this pull request Jan 7, 2025
@Sachin-chaurasiya
Minor: Enhance Block Editor Adjust drag-and-drop handles and improve …
22bc3b1 
…bar menu layout (#19228)

* Minor: Enhance Block Editor Adjust drag-and-drop handles and improve bar menu layout

* Refactor: Replace RichTextEditor with dynamic description fields in user and team forms

* Enhance AddNotificationPage and AddObservabilityPage to use RichTextEditor for description input

* Enhance AddNotificationPage and AddObservabilityPage to initialize RichTextEditor with alert description

(cherry picked from commit aceadb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sachin-chaurasiya @chirag-madlani