Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15600: Retention Application : Delete change_events, activity threads, versions based on admin retention policies #18913

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Dec 4, 2024

Describe your changes:

Fixes: #15600

Retention Policy App Diagram

Screenshot 2024-12-15 at 7 14 56 AM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.87% (40075/62747) 40.38% (16040/39724) 43.06% (4805/11160)

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

mohityadav766
mohityadav766 previously approved these changes Dec 16, 2024
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add some test cases like we are doing for other apps @Siddhanttimeline

@Siddhanttimeline Siddhanttimeline marked this pull request as draft December 16, 2024 11:20
Copy link

sonarcloud bot commented Dec 16, 2024

Copy link

sonarcloud bot commented Dec 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retention Application : Delete change_events, activity threads, versions based on admin retention policies
3 participants