[ucd/category] Fix typo in GeneralCategory::is_symbol() #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I closed this because I have made another pull request which includes this change: #61 |
behnam
changed the title
behnam
added a commit
that referenced
this pull request
Jul 27, 2017
The coverage test makes sure there's no overlap between major categories, except the case of `Cased_Letter` and `Letter`. The test can catch bugs like the one fixed in <#60>.
behnam
added a commit
that referenced
this pull request
Jul 28, 2017
The coverage test makes sure there's no overlap between major categories, except the case of `Cased_Letter` and `Letter`. The test can catch bugs like the one fixed in <#60>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was working on #43 I found this typo which was causing one of my tests to fail.
I haven't finished #43 yet but I figured I may as well fix the typo asap.
My first ever PR! :')