Issue open-horizon#4126 - Feature Request: Let agent-install.sh autom… #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarson04
requested changes
Aug 8, 2024
agent-install/agent-install.sh
Outdated
| log_warning "Cannot use agent image with $image_arch_in_param arch to install on $image_arch cluster, will change arch to '$image_arch'" | ||
| part1=$(echo $IMAGE_ON_EDGE_CLUSTER_REGISTRY | cut -d "/" -f 1) | ||
| part2=$(echo $IMAGE_ON_EDGE_CLUSTER_REGISTRY | cut -d "/" -f 2) | ||
| IMAGE_ON_EDGE_CLUSTER_REGISTRY=$part1/$part2/${image_arch}_anax_k8s |
There was a problem hiding this comment.
I think it would be better if we don't assume that IMAGE_ON_EDGE_CLUSTER_REGISTRY always has 3 parts. I used docker.io/dlarson04/horizon/amd64_anax_k8s one time and this failed. Can we add more code to find which part has *_anax_k8s ?
LiilyZhang
force-pushed
the
zhangl/Issue4126
branch
3 times, most recently
from
54d4fa5 to
2451a39
Compare
…atically substitute in the cluster architecture if IMAGE_ON_EDGE_CLUSTER_REGISTRY is specified Signed-off-by: Le Zhang <[email protected]>
LiilyZhang
force-pushed
the
zhangl/Issue4126
branch
from
2451a39 to
e9cd41b
Compare
dlarson04
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atically substitute in the cluster architecture if IMAGE_ON_EDGE_CLUSTER_REGISTRY is specified
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: