Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability CVE-2024-51744 that was found by Mend scan #4184

Open
omordyk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4187
Open

Vulnerability CVE-2024-51744 that was found by Mend scan #4184

omordyk opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4187
Assignees
Labels

Comments

@omordyk
Copy link

omordyk commented Dec 5, 2024

Vulnerability CVE-2024-51744 that was found by Mend scan
Description:

golang-jwt is a Go implementation of JSON Web Tokens. Unclear documentation of the error behavior in ParseWithClaims can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned by ParseWithClaims return both error codes. If users only check for the jwt.ErrTokenExpired using error.Is, they will ignore the embedded jwt.ErrTokenSignatureInvalid and thus potentially accept invalid tokens. A fix has been back-ported with the error handling logic from the v5 branch to the v4 branch. In this logic, the ParseWithClaims function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release. We are aware that this changes the behaviour of an established function and is not 100 % backwards compatible, so updating to 4.5.1 might break your code. In case you cannot update to 4.5.0, please make sure that you are properly checking for all errors ("dangerous" ones first), so that you are not running in the case detailed above.

@omordyk omordyk self-assigned this Dec 5, 2024
@omordyk omordyk linked a pull request Dec 5, 2024 that will close this issue
12 tasks
omordyk added a commit that referenced this issue Dec 5, 2024
omordyk added a commit that referenced this issue Dec 6, 2024
@omordyk omordyk linked a pull request Dec 16, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant