Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Object API-groups via django-setup-configuration #4787

Closed
Tracked by #4858
sjoerdie opened this issue Oct 24, 2024 · 0 comments · Fixed by #4822
Closed
Tracked by #4858

Add support for Object API-groups via django-setup-configuration #4787

sjoerdie opened this issue Oct 24, 2024 · 0 comments · Fixed by #4822
Assignees
@stevenbal
Labels
enhancement owner: dimpact topic: setup-config
Milestone
Release 3.0

Comments

@sjoerdie
Copy link
Contributor

Thema / Theme

Frontend

Omschrijving / Description

Add django-setup-configuration to configure openforms to objecten

Added value / Toegevoegde waarde

No response

Aanvullende opmerkingen / Additional context

No response
@sjoerdie sjoerdie added triage Issue needs to be validated. Remove this label if the issue considered valid. enhancement labels Oct 24, 2024
@stevenbal stevenbal removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 15, 2024
@stevenbal stevenbal moved this to In Progress in Development Nov 15, 2024
@stevenbal stevenbal mentioned this issue Nov 15, 2024
Merged
9 tasks
@joeribekker joeribekker changed the title Add django-setup-configuration to configure openforms to objecten Add support for Object API-groups via django-setup-configuration Nov 26, 2024
@joeribekker joeribekker mentioned this issue Nov 26, 2024
Closed
3 tasks
@stevenbal stevenbal moved this from In Progress to Implemented in Development Dec 2, 2024
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
⬆️ [#4787] Upgrade zgw-consumers to 0.36.0
c96d08b
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
👽 [#4787] Add missing Service.slug to fix service fetch tests
eb35947
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
✨ [#4787] Add ServiceConfigurationStep to steps
8c5281e 
this is needed to load the Services required to setup configuration such as ObjectsAPIGroupConfig, etc.
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🐳 [#4787] Docker compose setup for setup-configuration
e0747b3 
add a web-init container and the required scripts for setup_configuration. Example data has been added to docker/setup_configuration
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
✨ [#4787] ConfigurationStep for Objects API registration config
ef11757 
this step relies on the previously added ServiceConfigurationStep and can be used to set up the necessary configuration for the Objects API registration backend
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
✅ [#4787] Add tests for Objects API config step
accd9ab
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🐳 [#4787] Disable setup_config command in upgrade tests
5ee59bd 
to avoid having to bring up the Open Zaak and Objects/Objecttypes docker compose stacks for the CI tests to simulate upgrading Open Forms
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
📝 [#4787] Documentation for setup_configuration
ecbc5ff
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
✨ [#4787] Add identifier field to ObjectsAPIGroupConfig
3fc61df 
to make sure there is a unique field that can be used to refer to the groups and identify them when they are loaded using setup-configuration
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
♻️ [#4787] Changes to setup_config implementation after discussion
255182f 
* Make Documenten and Catalogi API optional in config model
* Add identifier
* Use lowercase namespaces
* Remove is_configured and validate_result
* add tests for required fields, all fields and idempotency
* Rename service_slug to service_identifier
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🐳 [#4787] Update setup_configuration docker setup
603d154 
identifiers were added instead of slugs, and the selftest functionality has been removed
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🚚 [#4787] Move setup config code to objects_api contrib directory
6f1481a 
since this is all tightly coupled with the objects API models, the steps and models should be defined there as well
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
👽 [#4787] Changes according to setup-configuration lib changes
3c0091c 
* setup_configuration now only takes one yaml file as a source
* remove legacy `is_configured` and `validate_result` hooks
* change testing utils
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
💚 [#4787] Ignore ConfigurationStep with pyright in CI
d9478d3 
currently django_model_refs are not recognized as attributes on the model, an upstream issue has been created for this
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🚚 [#4787] Rename several fields on Objects API config model
4f92c5b
stevenbal added a commit that referenced this issue Dec 3, 2024
@stevenbal
🚚 [#4787] Rename several fields on Objects API config model
0d16714
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
⬆️ [#4787] Upgrade zgw-consumers to 0.36.0
0333c63
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
👽 [#4787] Add missing Service.slug to fix service fetch tests
0850a24
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
✨ [#4787] Add ServiceConfigurationStep to steps
48230fa 
this is needed to load the Services required to setup configuration such as ObjectsAPIGroupConfig, etc.
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
🐳 [#4787] Docker compose setup for setup-configuration
83c2bc7 
add a web-init container and the required scripts for setup_configuration. Example data has been added to docker/setup_configuration
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
✨ [#4787] ConfigurationStep for Objects API registration config
5d65975 
this step relies on the previously added ServiceConfigurationStep and can be used to set up the necessary configuration for the Objects API registration backend
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
✅ [#4787] Add tests for Objects API config step
2220c61
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
🐳 [#4787] Disable setup_config command in upgrade tests
4b72ee4 
to avoid having to bring up the Open Zaak and Objects/Objecttypes docker compose stacks for the CI tests to simulate upgrading Open Forms
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
📝 [#4787] Documentation for setup_configuration
66942ce
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
✨ [#4787] Add identifier field to ObjectsAPIGroupConfig
556bf61 
to make sure there is a unique field that can be used to refer to the groups and identify them when they are loaded using setup-configuration
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
♻️ [#4787] Changes to setup_config implementation after discussion
01b9255 
* Make Documenten and Catalogi API optional in config model
* Add identifier
* Use lowercase namespaces
* Remove is_configured and validate_result
* add tests for required fields, all fields and idempotency
* Rename service_slug to service_identifier
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
🐳 [#4787] Update setup_configuration docker setup
fe5ad02 
identifiers were added instead of slugs, and the selftest functionality has been removed
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
🚚 [#4787] Move setup config code to objects_api contrib directory
9409374 
since this is all tightly coupled with the objects API models, the steps and models should be defined there as well
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
👽 [#4787] Changes according to setup-configuration lib changes
d710652 
* setup_configuration now only takes one yaml file as a source
* remove legacy `is_configured` and `validate_result` hooks
* change testing utils
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
💚 [#4787] Ignore ConfigurationStep with pyright in CI
47f7a02 
currently django_model_refs are not recognized as attributes on the model, an upstream issue has been created for this
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
🚚 [#4787] Rename several fields on Objects API config model
c16c4fe
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
👌 [#4787] Process PR feedback
edd2b72 
* add type: ignore to specific lines in steps.py instead of ignoring entire file with pyright
* several docs improvements
* remove unused SCRIPTPATH variable in wait_for_db.sh and setup_configuration.sh
* move tests to objects_api.tests directory
stevenbal added a commit that referenced this issue Dec 6, 2024
@stevenbal
👌 [#4787] Process PR feedback
07c23a6 
* add type: ignore to specific lines in steps.py instead of ignoring entire file with pyright
* several docs improvements
* remove unused SCRIPTPATH variable in wait_for_db.sh and setup_configuration.sh
* move tests to objects_api.tests directory
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Dec 6, 2024
@sergei-maertens sergei-maertens added this to the Release 3.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevenbal stevenbal

Labels
enhancement owner: dimpact topic: setup-config
Projects
Development
Archived in project
Milestone
Release 3.0
Development

Successfully merging a pull request may close this issue.

✨ [#4788] ConfigurationStep for Objects API registration config open-formulieren/open-forms
4 participants
@joeribekker @sergei-maertens @stevenbal @sjoerdie