Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New form builder - styling does not support dark mode #3774

Closed
5 tasks done
sergei-maertens opened this issue Jan 12, 2024 · 2 comments · Fixed by #3790, #3784 or open-formulieren/formio-builder#117
Closed
5 tasks done

New form builder - styling does not support dark mode #3774

sergei-maertens opened this issue Jan 12, 2024 · 2 comments · Fixed by #3790, #3784 or open-formulieren/formio-builder#117
Assignees
@sergei-maertens
Labels
design needs-backport Fix must be backported to stable release branch topic: admin
Milestone
Release 2.5.2

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Jan 12, 2024 •
edited
Loading

The new form builder CSS does not support dark mode yet.

Components affected (there may be more, please check)

  • Dropdowns
    image
  • Preview buttons
    image
  • Translations table
    image
  • Validation > error message translations table
    image
  • JSON preview
    image
@sergei-maertens sergei-maertens added this to the Release 2.5.0 milestone Jan 12, 2024
@joeribekker joeribekker moved this from Todo to In Progress in Development Jan 16, 2024
@Viicos
Copy link
Contributor

Viicos commented Jan 16, 2024 •
edited
Loading

Fixed:
image
image
image
image

@Viicos
Copy link
Contributor

Viicos commented Jan 16, 2024

For the react-select component, this will most probably require some work

Viicos added a commit to open-formulieren/formio-builder that referenced this issue Jan 16, 2024
@Viicos
[open-formulieren/open-forms#3774] Fix dark mode compatibility
cab3be3
@Viicos Viicos mentioned this issue Jan 16, 2024
Merged
Viicos added a commit that referenced this issue Jan 16, 2024
@Viicos
[#3774] Fix dark mode compatibility
78cc90e
@Viicos Viicos mentioned this issue Jan 16, 2024
Merged
@Viicos Viicos moved this from In Progress to Implemented in Development Jan 17, 2024
Viicos added a commit to open-formulieren/formio-builder that referenced this issue Jan 18, 2024
@Viicos
Merge pull request #110 from open-formulieren/dark-mode-fixes
44741a6 
[open-formulieren/open-forms#3774] Fix dark mode compatibility
Viicos added a commit that referenced this issue Jan 18, 2024
@Viicos
Merge pull request #3784 from open-formulieren/dark-mode-compatibility
eb19082 
[#3774] Fix dark mode compatibility
Viicos added a commit that referenced this issue Jan 22, 2024
@Viicos
[#3774] Update to [email protected]
7fa0eec
@Viicos Viicos mentioned this issue Jan 22, 2024
Merged
sergei-maertens added a commit that referenced this issue Jan 22, 2024
@sergei-maertens
Merge pull request #3790 from open-formulieren/issue/3774-dark-mode-i…
50550c0 
…ssues

[#3774] Update to `[email protected]`
@sergei-maertens sergei-maertens linked a pull request Jan 23, 2024 that will close this issue
[#3774] Update to [email protected] #3790
Merged
@sergei-maertens sergei-maertens moved this from Implemented to Todo in Development Jan 23, 2024
@sergei-maertens sergei-maertens linked a pull request Jan 23, 2024 that will close this issue
[#3774] Fix dark mode compatibility #3784
Merged
@sergei-maertens sergei-maertens moved this from Todo to In Progress in Development Jan 26, 2024
@sergei-maertens sergei-maertens mentioned this issue Jan 26, 2024
Merged
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Jan 26, 2024
@sergei-maertens
⬆️ [open-formulieren/open-forms#3774] Bump to react-select 5.8
f9c93c7 
Minor version has accessibility improvements, which should also make
(interaction) testing easier since the proper aria roles are now set.
sergei-maertens added a commit to open-formulieren/formio-builder that referenced this issue Jan 26, 2024
@sergei-maertens
💄 [open-formulieren/open-forms#3774] Define react-select styles to su…
13d05eb 
…pport light/dark theme
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development Jan 26, 2024
@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Jan 26, 2024
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Jan 31, 2024
sergei-maertens added a commit that referenced this issue Jan 31, 2024
@sergei-maertens
⬆️ [#3774] Upgrade to dark-mode compatible form builder (react-select)
cc479a4
sergei-maertens added a commit that referenced this issue Jan 31, 2024
@sergei-maertens
⬆️ [#3774] Upgrade to dark-mode compatible form builder (react-select)
a0698d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
design needs-backport Fix must be backported to stable release branch topic: admin
Projects
Development
Archived in project
Milestone
Release 2.5.2
3 participants
@joeribekker @sergei-maertens @Viicos