Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vitest 3 #779

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Upgrade to Vitest 3 #779

merged 2 commits into from
Jan 22, 2025

Conversation

sergei-maertens
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 22, 2025

Bundle Report

Changes will decrease total bundle size by 1.25kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.7MB 864 bytes (-0.02%) ⬇️
@open-formulieren/sdk-esm 4.7MB 391 bytes (-0.01%) ⬇️

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (7c68240) to head (b6776e0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   75.77%   83.25%   +7.47%     
==========================================
  Files         222      238      +16     
  Lines        4582     4729     +147     
  Branches     1252     1274      +22     
==========================================
+ Hits         3472     3937     +465     
+ Misses       1106      757     -349     
- Partials        4       35      +31     
Flag Coverage Δ
storybook 75.66% <ø> (-0.11%) ⬇️
vitest 62.78% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Upgraded from vitest 2 to vitest 3, so now we only depend
on one version of Vite in the whole project.

Additionally, rollup was explicitly added to the dev
dependencies so that the type imports are picked up by
TS - it is a direct dependency of Vite already so
nothing really changed except for TS being able to
resolve the types.
undici (the node fetch implementation) is affected by this because
it uses queueMicrotask, leading to OOM / never completing tests
that use fake timers. See
vitest-dev/vitest#7288 for more
complete information.
@sergei-maertens sergei-maertens merged commit de56b14 into main Jan 22, 2025
15 of 17 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-vitest branch January 22, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant