✨ Add currency component
#50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Nov 6, 2023
Viicos
commented
Nov 6, 2023
Viicos
commented
Nov 6, 2023
| const defaultValueSchema = singleValueSchema.or(multipleValueSchema); | ||
|
|
||
| const currencySpecific = z.object({ | ||
| decimalLimit: z.number().int().positive().optional(), |
There was a problem hiding this comment.
the types restrict this to the values 0-9 (maybe 10), so perhaps we should do the same here?
z.union([z.literal(0), z.literal(1), z.literal(2)]) etc. (you can write a nice Array(9).map for this probably).
There was a problem hiding this comment.
Fixed, had to cast as any because it doesn't typecheck somehow
sergei-maertens
requested changes
Nov 9, 2023
sergei-maertens
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.