Implement file component #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergei-maertens
force-pushed
the
feature/file-component-edit-form
branch
from
c5d64e7 to
408e1aa
Compare
* Expose file types from context - the backend needs to feed the list of possible options to the builder. * Extend decorators and stories to handle (default) file types * Add file name template field * Add file type (multi) select * Add 'use global config file types' checkbox * Add 'maxFileSize' textbox * Add 'maxNumberOfFiles' number field The input validation is added as todo for a separate commit.
sergei-maertens
force-pushed
the
feature/file-component-edit-form
branch
2 times, most recently
from
0f672dd to
427cd56
Compare
* Show image resizing options * Reset image resizing configuration if no image content type is selected * Implemented derived/calculated component properties from file types config field
sergei-maertens
force-pushed
the
feature/file-component-edit-form
branch
from
427cd56 to
3179e42
Compare
* Process the possible document types per backend/domain into optgroups for react-select to properly display. * Fetch confidentiality levels from backend/context * Add bronorganisatie and title fields
sergei-maertens
commented
Oct 26, 2023
sergei-maertens
commented
Oct 26, 2023
sergei-maertens
commented
Oct 26, 2023
sergei-maertens
commented
Oct 26, 2023
sergei-maertens
commented
Oct 26, 2023
Comment on lines
+213
to
+215
| <Component type="columns"> | ||
| <div className="columns"> | ||
| <div className="column column--span-md"> |
There was a problem hiding this comment.
column styles are in the backend CSS, so they're displayed in a single column in storybook
The useAsync hook runs before the select component even renders, so there is some execution time that may cause the 'loading...' message to never display or too briefly for the testing tools to pick it up.
sergei-maertens
force-pushed
the
feature/file-component-edit-form
branch
from
7ada014 to
a1378f3
Compare
Contains the fixes for the file upload component.
sergei-maertens
force-pushed
the
feature/file-component-edit-form
branch
from
7e9f246 to
453a235
Compare
SilviaAmAm
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes open-formulieren/open-forms#2958
Implement the file component in the new form builder, which scopes the translations to the component itself and should resolve these translation issues.