💚 Try to make tests more reliable

Part too-many.
open-formulieren · Nov 13, 2023 · 70fcd21 · 70fcd21
1 parent 006ae2f
commit 70fcd21
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 22 deletions.
diff --git a/src/components/builder/validate/validator-select.stories.tsx b/src/components/builder/validate/validator-select.stories.tsx
@@ -47,7 +47,7 @@ export const Default: Story = {
     const input = canvas.getByLabelText('Plugin(s)');
 
     // open the dropdown
-    input.focus();
+    await userEvent.click(input);
     await userEvent.keyboard('[ArrowDown]');
 
     await step('Check available options displayed', async () => {

diff --git a/src/registry/file/file-validation.stories.ts b/src/registry/file/file-validation.stories.ts
@@ -103,33 +103,39 @@ export const MaxFileSize: Story = {
       await userEvent.clear(fileSize);
       await userEvent.type(fileSize, '-10MB');
       await userEvent.keyboard('[Tab]');
-      expect(
-        await canvas.findByText(
-          'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
-        )
-      ).toBeVisible();
+      await waitFor(async () => {
+        expect(
+          await canvas.findByText(
+            'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
+          )
+        ).toBeVisible();
+      });
     });
 
     await step('Decimal file size (period)', async () => {
       await userEvent.clear(fileSize);
       await userEvent.type(fileSize, '10.5MB');
       await userEvent.keyboard('[Tab]');
-      expect(
-        await canvas.findByText(
-          'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
-        )
-      ).toBeVisible();
+      await waitFor(async () => {
+        expect(
+          await canvas.findByText(
+            'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
+          )
+        ).toBeVisible();
+      });
     });
 
     await step('Decimal file size (comma)', async () => {
       await userEvent.clear(fileSize);
       await userEvent.type(fileSize, '10,5 MB');
       await userEvent.keyboard('[Tab]');
-      expect(
-        await canvas.findByText(
-          'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
-        )
-      ).toBeVisible();
+      await waitFor(async () => {
+        expect(
+          await canvas.findByText(
+            'Specify a positive, non-zero file size without decimals, e.g. 10MB.'
+          )
+        ).toBeVisible();
+      });
     });
   },
 };
@@ -147,18 +153,22 @@ export const ValidMaxFileSize: Story = {
       await userEvent.clear(fileSize);
       await userEvent.type(fileSize, '15    mb');
       await userEvent.keyboard('[Tab]');
-      expect(
-        canvas.queryByText('Specify a positive, non-zero file size without decimals, e.g. 10MB.')
-      ).not.toBeInTheDocument();
+      await waitFor(async () => {
+        expect(
+          canvas.queryByText('Specify a positive, non-zero file size without decimals, e.g. 10MB.')
+        ).not.toBeInTheDocument();
+      });
     });
 
     await step('Accept non-MB values', async () => {
       await userEvent.clear(fileSize);
       await userEvent.type(fileSize, '200 KB');
       await userEvent.keyboard('[Tab]');
-      expect(
-        canvas.queryByText('Specify a positive, non-zero file size without decimals, e.g. 10MB.')
-      ).not.toBeInTheDocument();
+      await waitFor(async () => {
+        expect(
+          canvas.queryByText('Specify a positive, non-zero file size without decimals, e.g. 10MB.')
+        ).not.toBeInTheDocument();
+      });
     });
   },
 };