-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: section clarity, harden API, providers #149
Conversation
Signed-off-by: Todd Baert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the spec version numbers may require numerous changes to tests in various SDKs. That doesn't necessary mean we can make the change but we should be aware of the impact.
Signed-off-by: Todd Baert <[email protected]>
100%. I know this changes some tests, but this change should actually reduce such thrashing in the future and makes things more consistent. Provider was the only section where the requirements didn't have 3 decimal places. |
An alternative to marking all of |
@justinabrahms do you have any objections to this? (I volunteer to absorb the test-renumbering in the java-sdk) |
Marking Evaluation API and Providers
hardening
and a few non-functional changes here that improve structure.specifically:
An alternative to marking all of
provider
andevaluation API
as hardening would be just marking all existing sections therein as hardening, which might be better since we'd have to do that anyway if we added a new experimental section.see: #146 for more on release goals.