-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metadata endpoint #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
requested review from
beeme1mr,
jonathannorris,
Kavindu-Dodan,
toddbaert and
lukas-reining
April 7, 2024 19:33
nicklasl
reviewed
Apr 8, 2024
Signed-off-by: Thomas Poignant <[email protected]>
nicklasl
reviewed
Apr 8, 2024
nicklasl
reviewed
Apr 8, 2024
Signed-off-by: Thomas Poignant <[email protected]>
Co-authored-by: Jonathan Norris <[email protected]> Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
metadata-endpoint
branch
from
April 8, 2024 18:15
15307c0
to
dda7fdb
Compare
kinyoklion
reviewed
Apr 8, 2024
Co-authored-by: Ryan Lamb <[email protected]> Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
metadata-endpoint
branch
from
April 8, 2024 19:11
77a3863
to
062b5d7
Compare
beeme1mr
reviewed
Apr 8, 2024
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
…dpoint name Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
nicklasl
reviewed
Apr 10, 2024
Signed-off-by: Thomas Poignant <[email protected]>
beeme1mr
reviewed
Apr 16, 2024
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
beeme1mr
approved these changes
Apr 17, 2024
lukas-reining
approved these changes
Apr 17, 2024
Kavindu-Dodan
approved these changes
Apr 18, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR adds the support of a new endpoint
/ofrep/v1/configuration
in the OFREP OpenAPI spec.This new endpoint is here to be able to expose some information about the flag management system to the generic provider.
This endpoint will be called during the initialization of the provider and will allow the provider to configure itself based on the configuration received.
This endpoint will return basic information such as the
name
of the flag management system.But also what
features
are supported by the remote flag management systems, and basic remote configuration on how the provider should behave.This 1st version does not contain a lot of possible configuration, but we will be able to extend it as we continue to evolve the OpenFeature Remote Evaluation Protocol.