-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update psr/log #74
Conversation
8ee336a
to
38f42b8
Compare
Relates to: #41 |
Correct @beeme1mr . I am deprecating 7.4 support in this library shortly so this won't be a blocker soon. See this comment for info: #41 (comment) @kidager thank you for the PR! I will merge this after the 7.4 deprecation and coinciding changes to the SDK are merged. |
I missed that PR (and thus comment). |
No worries! I've gotten the core SDK upgraded so that PHP 7.4 is deprecated. Next up, I'll be updated the contrib packages. For now, you should be able to rebase and make any necessary changes to support newer psr/log versions 🙂 |
This is going to be a bit difficult I would think- since the interfaces actually do change between these versions we may have to target the latest. Perhaps dropping only version 1 may work though |
Signed-off-by: Jacem Chaieb <[email protected]>
You're right, for now I've rebased and made the changes, the pre-commit checks are passing. Will push and check if the different builds are working fine, if that's the case then bingo. |
38f42b8
to
f17ec35
Compare
Signed-off-by: Tom Carrio <[email protected]>
@kidager this change is now applicable with the deprecation of PHP 7.4 I went ahead and bumped 1.1 out of the versions since it was incompatible, as we had discussed. This unblocks utilizing OpenFeature with projects like Laravel. Thank you again for your contribution! 🎉 |
50573ec
to
92786f6
Compare
Signed-off-by: Tom Carrio <[email protected]>
92786f6
to
c5916f0
Compare
Signed-off-by: Tom Carrio <[email protected]>
Well, sorry @kidager, there are more issues this caused than expected. We have the Flagd provider in open-feature/php-sdk-contrib and integration tests for the php-sdk against it in this repo- so we're seeing a bit of a chicken & egg scenario here. If this takes much longer I'm going to branch off your changes so I'm not creating as much noise for you 🙏 |
And actually that was the last of the changes needed. LGTM 🚀 |
🤖 I have created a release *beep* *boop* --- ## [2.0.1](2.0.0...2.0.1) (2023-05-16) ### Miscellaneous Chores * **deps:** update dependency php to v8.2.3 ([#73](#73)) ([27d1bbc](27d1bbc)) * **deps:** update dependency phpstan/phpstan to ~1.10.0 ([#87](#87)) ([f59da40](f59da40)) * **deps:** update dependency vimeo/psalm to ~5.8.0 ([#72](#72)) ([800119f](800119f)) * remove deprecated --no-suggest composer flag ([#89](#89)) ([2adecfb](2adecfb)) * update psr/log ([#74](#74)) ([f8a67c7](f8a67c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR
psr/log
version requirementsNotes
Some projects require other versions of
psr/log
than1.*
Example:
On a fresh Laravel 9 project, running
composer require open-feature/sdk
yields the following error: