feat: add named provider metadata accessor #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeme1mr
changed the title
beeme1mr
commented
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
reviewed
Dec 11, 2023
toddbaert
approved these changes
Dec 11, 2023
beeme1mr
commented
Dec 11, 2023
beeme1mr
commented
Dec 11, 2023
Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]> Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
toddbaert
force-pushed
the
add-named-client-metadata-accessor
branch
from
e58f310 to
b0c1d1b
Compare
This was referenced Dec 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.21](core-v0.0.20...core-v0.0.21) (2023-12-18) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.8.0](server-sdk-v1.7.5...server-sdk-v1.8.0) (2024-01-03) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) ### 🧹 Chore * **main:** release core 0.0.21 ([#720](#720)) ([7d1aca4](7d1aca4)) * update flagd-provider ([#723](#723)) ([c7098c3](c7098c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.9](web-sdk-v0.4.8...web-sdk-v0.4.9) (2024-01-08) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) * add PROVIDER_CONTEXT_CHANGED event (web-sdk only) ([#731](#731)) ([7906bbe](7906bbe)) ### 🐛 Bug Fixes * use in memory provider for e2e suites ([#740](#740)) ([696bf4a](696bf4a)) ### 🧹 Chore * **main:** release core 0.0.21 ([#720](#720)) ([7d1aca4](7d1aca4)) * **main:** release core 0.0.22 ([#745](#745)) ([a0cc855](a0cc855)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
## This PR - adds an accessor for named provider metadata ### Related Issues Fixes #714 ### Notes The default metadata is returned if the name doesn't match a registered provider. This is another example where provider namespace would work well. It doesn't make sense to call this "named client" since we are only interested in the client. --------- Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.21](core-v0.0.20...core-v0.0.21) (2023-12-18) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [1.8.0](server-sdk-v1.7.5...server-sdk-v1.8.0) (2024-01-03) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) ### 🧹 Chore * **main:** release core 0.0.21 ([#720](#720)) ([7d1aca4](7d1aca4)) * update flagd-provider ([#723](#723)) ([c7098c3](c7098c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.9](web-sdk-v0.4.8...web-sdk-v0.4.9) (2024-01-08) ### ✨ New Features * add named provider metadata accessor ([#715](#715)) ([23d14aa](23d14aa)) * add PROVIDER_CONTEXT_CHANGED event (web-sdk only) ([#731](#731)) ([7906bbe](7906bbe)) ### 🐛 Bug Fixes * use in memory provider for e2e suites ([#740](#740)) ([696bf4a](696bf4a)) ### 🧹 Chore * **main:** release core 0.0.21 ([#720](#720)) ([7d1aca4](7d1aca4)) * **main:** release core 0.0.22 ([#745](#745)) ([a0cc855](a0cc855)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #714
Notes
The default metadata is returned if the name doesn't match a registered provider.
This is another example where provider namespace would work well. It doesn't make sense to call this "named client" since we are only interested in the client.