fix: type support for Promise<void> before hook #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
commented
Nov 27, 2023
toddbaert
reviewed
Nov 28, 2023
Signed-off-by: Michael Beemer <[email protected]>
toddbaert
approved these changes
Nov 28, 2023
toddbaert
changed the title
|
@beeme1mr I made slight changes to the title. Hope you don't mind. Feel free to merge if you're OK with it. |
beeme1mr
deleted the
689-bug-typings-dont-support-returning-promisevoid
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5) (2023-12-08) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) * type support for Promise<void> before hook ([#693](#693)) ([0b9ca18](0b9ca18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [1.7.5](server-sdk-v1.7.4...server-sdk-v1.7.5) (2023-12-08) ### 🐛 Bug Fixes * handlers should run immediately ([#701](#701)) ([dba858b](dba858b)) * type support for Promise<void> before hook ([#693](#693)) ([0b9ca18](0b9ca18)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #689
Notes
I added a test but the test runner isn't not validating types.