feat(server): add in memory provider #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Ribeiro <[email protected]>
luizgribeiro
changed the title
|
Hey @luizgribeiro I think the only thing we need here is the provider code. You can remove the There's also a couple lint errors, and some imports are broken (you will need to use relative imports for the stuff from the server package, or import from Lastly - a question - is this actually a breaking change? I don't think so 🤔 |
toddbaert
changed the title
Signed-off-by: Todd Baert <[email protected]>
toddbaert
reviewed
Oct 10, 2023
toddbaert
requested review from
toddbaert,
beeme1mr,
lukas-reining and
Kavindu-Dodan
beeme1mr
approved these changes
Oct 10, 2023
packages/server/src/provider/in-memory-provider/flag-configuration.ts
Outdated
Show resolved
Hide resolved
packages/server/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
packages/server/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
beeme1mr
changed the title
Kavindu-Dodan
approved these changes
Oct 10, 2023
…ider.ts Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Luiz Ribeiro <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
approved these changes
Oct 11, 2023
beeme1mr
approved these changes
Oct 11, 2023
toddbaert
reviewed
Oct 11, 2023
packages/server/src/provider/in-memory-provider/in-memory-provider.ts
Outdated
Show resolved
Hide resolved
…ider.ts Signed-off-by: Todd Baert <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Oct 11, 2023
🤖 I have created a release *beep* *boop* --- ## [1.6.0](js-sdk-v1.5.0...js-sdk-v1.6.0) (2023-10-11) ### Features * **server:** add in memory provider ([#585](#585)) ([5e044ef](5e044ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implements the following features for
inMemoryProvider:Related Issues
It's part of #565
Follow-up Tasks
How to test
Unit tests were also implemented to assure that it is working