feat: re-render if flagsChanged is falsy #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Dec 4, 2024
beeme1mr
approved these changes
Dec 4, 2024
lukas-reining
approved these changes
Dec 4, 2024
toddbaert
pushed a commit
that referenced
this pull request
Dec 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.9](react-sdk-v0.4.8...react-sdk-v0.4.9) (2024-12-04) ### ✨ New Features * re-render if flagsChanged is falsy ([#1095](#1095)) ([78516f4](78516f4)) ### 📚 Documentation * fix typos, links, and format ([#1075](#1075)) ([418409e](418409e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
wichopy
pushed a commit
to wichopy/openfeature-js-sdk
that referenced
this pull request
Dec 31, 2024
Adds an improvement to the React SDK which supports re-renders if the [flags changed](https://open-feature.github.io/js-sdk/types/_openfeature_server_sdk.ConfigChangeEvent.html) array from a provider event is falsy. Since some providers have no knowledge of flags which are changed, this allows them to support dynamic re-rendering by not defining this property. If the prop is null/undefined, we diff all flags... If the property is explicitly set to an empty array, that means no flags have changed and the React SDK skips all diff checks. Signed-off-by: Todd Baert <[email protected]> Signed-off-by: Will Chou <[email protected]>
wichopy
pushed a commit
to wichopy/openfeature-js-sdk
that referenced
this pull request
Dec 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.9](open-feature/js-sdk@react-sdk-v0.4.8...react-sdk-v0.4.9) (2024-12-04) ### ✨ New Features * re-render if flagsChanged is falsy ([open-feature#1095](open-feature#1095)) ([78516f4](open-feature@78516f4)) ### 📚 Documentation * fix typos, links, and format ([open-feature#1075](open-feature#1075)) ([418409e](open-feature@418409e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Will Chou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an improvement to the React SDK which supports re-renders if the flags changed array from a provider event is falsy.
Since some providers have no knowledge of flags which are changed, this allows them to support dynamic re-rendering by not defining this property. If the prop is null/undefined, we diff all flags... If the property is explicitly set to an empty array, that means no flags have changed and the React SDK skips all diff checks.