chore: import type lint rule and fixes #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
weyert,
beeme1mr,
aepfli,
lukas-reining and
RealAnna
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
reviewed
Oct 16, 2024
toddbaert
commented
Oct 16, 2024
| "error", | ||
| { | ||
| "disallowTypeAnnotations": true, | ||
| "fixStyle": "separate-type-imports", |
There was a problem hiding this comment.
There's an alternative to this which adds type to each individual import... this adds type to the entire import line. I don't care which we use.
beeme1mr
approved these changes
Oct 16, 2024
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
approved these changes
Oct 16, 2024
This was referenced Oct 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](core-v1.4.0...core-v1.5.0) (2024-10-29) ### ✨ New Features * implement tracking as per spec ([#1020](#1020)) ([80f182e](80f182e)) ### 🧹 Chore * import type lint rule and fixes ([#1039](#1039)) ([01fcb93](01fcb93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](web-sdk-v1.2.4...web-sdk-v1.3.0) (2024-10-29) ### ✨ New Features * implement tracking as per spec ([#1020](#1020)) ([80f182e](80f182e)) ### 🧹 Chore * import type lint rule and fixes ([#1039](#1039)) ([01fcb93](01fcb93)) * **main:** release core 1.5.0 ([#1040](#1040)) ([fe3ad8e](fe3ad8e)) ### 📚 Documentation * update domain context terminology ([#1037](#1037)) ([924802b](924802b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.7](react-sdk-v0.4.6...react-sdk-v0.4.7) (2024-10-29) ### ✨ New Features * avoid re-resolving flags unaffected by a change event ([#1024](#1024)) ([b8f9b4e](b8f9b4e)) * implement tracking as per spec ([#1020](#1020)) ([80f182e](80f182e)) * use mutate context hook ([#1031](#1031)) ([ec3d967](ec3d967)) ### 🧹 Chore * add js docs for context mutator hook ([#1045](#1045)) ([def3fe8](def3fe8)) * import type lint rule and fixes ([#1039](#1039)) ([01fcb93](01fcb93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert
added a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [1.16.0](server-sdk-v1.15.1...server-sdk-v1.16.0) (2024-10-29) ### ✨ New Features * implement tracking as per spec ([#1020](#1020)) ([80f182e](80f182e)) ### 🧹 Chore * import type lint rule and fixes ([#1039](#1039)) ([01fcb93](01fcb93)) * **main:** release core 1.5.0 ([#1040](#1040)) ([fe3ad8e](fe3ad8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: Todd Baert <[email protected]> Co-authored-by: Todd Baert <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.2](nestjs-sdk-v0.2.1-experimental...nestjs-sdk-v0.2.2) (2024-10-29) ### 🧹 Chore * import type lint rule and fixes ([#1039](#1039)) ([01fcb93](01fcb93)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by this comment I've added a lint rule to enforce
import type, and some additional package changes to add alint:fix.The only changes I made manually here is to add the lint rule, and the package.json script. All the changes are auto-generated by the
lint:fix.