You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have set the named context and provider, and created a named client, if the context is working, I should get the on variant, but I got off, after open DevTools, the context didn't pass to flagd service.
When I use the empty name for context, provider, and client, the context is passed to flagd service as my expectation.
So I guess the named context is currently not working.
Hey @wellwind, thanks for the detailed issue and example repo. I've opened a PR to address the problem. The fix should be released in the next few days. Thanks!
## This PR
- adds domain as a concept to the server and web SDK
- adds a deprecation warning anywhere client name was exposed to users.
- fixes an issue in the web SDK where context set on a domain before a
provider is registered was not used.
## Addresses
fixes#8204aa9657
### Notes
This change is based on [this
spec](open-feature/spec#229) change. I tried to
make it a non-breaking change but I may have missed an untested
condition. Please carefully review to make sure I didn't miss anything.
### Follow-up Tasks
- Update the doc readme parser to support "domain".
- Update the NestJS and React SDKS. We should consider making those a
breaking change since they're sub 1.0.
---------
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Observed behavior
Following is my code:
and
flags.json
Expected Behavior
I have set the named context and provider, and created a named client, if the context is working, I should get the
on
variant, but I gotoff
, after open DevTools, the context didn't pass to flagd service.When I use the empty name for context, provider, and client, the context is passed to flagd service as my expectation.
So I guess the named context is currently not working.
Steps to reproduce
I have a reproduced repo
https://github.com/wellwind/flagd-context-demo
in
src/main.ts
,if I setclientName
to any non empty name, the flag result will befalse
, when I setclientName
to''
, I can get thetrue
result.The text was updated successfully, but these errors were encountered: