Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use in-memory provider for e2e suites #712

Closed
toddbaert opened this issue Dec 11, 2023 · 1 comment · Fixed by #740
Closed

Use in-memory provider for e2e suites #712

toddbaert opened this issue Dec 11, 2023 · 1 comment · Fixed by #740
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Dec 11, 2023 •
edited
Loading

Currently, we use flagd for e2e testing in this repo (see following links). Now that we have in-memory providers for both web and server, we should remove the dependency on flagd and use the in-memory providers for these gherkin suites.

Remove this file: https://github.com/open-feature/js-sdk/blob/main/packages/server/e2e/step-definitions/setup.ts and this file: https://github.com/open-feature/js-sdk/blob/main/packages/client/e2e/step-definitions/setup.ts and configure the in-memory provider in the evaluation.spec gherkin implementations themselves (here and here).
@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 11, 2023
@znonthedev znonthedev mentioned this issue Dec 29, 2023
Merged
@znonthedev
Copy link
Member

Raised a PR for the above. Please review

github-merge-queue bot pushed a commit that referenced this issue Jan 5, 2024
@znonthedev @beeme1mr @toddbaert
fix: use in memory provider for e2e suites (#740)
696bf4a 
## This PR
Removes setup using Flagd Provider and uses In-Memory Provider

Fixes #712

---------

Signed-off-by: Mohamed V J <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert added a commit that referenced this issue Jan 11, 2024
@znonthedev @beeme1mr @toddbaert
fix: use in memory provider for e2e suites (#740)
41b4fdc 
## This PR
Removes setup using Flagd Provider and uses In-Memory Provider

Fixes #712

---------

Signed-off-by: Mohamed V J <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Michael Beemer <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use in memory provider for e2e suites znonthedev/js-sdk
2 participants
@znonthedev @toddbaert