Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gofeatureflag): Clear cache if configuration changes + provider refactoring #947

Merged
merged 9 commits into from
Jun 26, 2024
Merged

feat(gofeatureflag): Clear cache if configuration changes + provider refactoring #947

merged 9 commits into from
Jun 26, 2024

Conversation

thomaspoignant
Copy link
Member

This PR

  • Clear cache if GO Feature Flag configuration is changing.
  • Refactor the code base to have a better separation of components.

@thomaspoignant thomaspoignant changed the title feat(gofeatureflag): Clear cache if configuration changes + refactoring feat(gofeatureflag): Clear cache if configuration changes + provider refactoring Jun 17, 2024
@thomaspoignant
fix: lint
d0a8981 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant marked this pull request as ready for review June 17, 2024 19:59
@thomaspoignant thomaspoignant requested a review from a team as a code owner June 17, 2024 19:59
@thomaspoignant thomaspoignant mentioned this pull request Jun 18, 2024
Merged
3 tasks
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Closed
lukas-reining
lukas-reining approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great! Just left two small comments.

@thomaspoignant thomaspoignant merged commit 338123f into main Jun 26, 2024
6 checks passed
@thomaspoignant thomaspoignant deleted the feat-polling-api branch June 26, 2024 07:12
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
@thomaspoignant thomaspoignant mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas-reining lukas-reining lukas-reining approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaspoignant @lukas-reining