feat!: add metrics hook #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
commented
Jul 7, 2023
toddbaert
commented
Jul 7, 2023
beeme1mr
reviewed
Jul 10, 2023
|
The implementation looks good. Waiting for other dependencies to be resolved |
toddbaert
force-pushed
the
feat/metrics
branch
2 times, most recently
from
85f4ba0
to
bd6596d
Compare
* add metrics hook * rename open-telemetry hook to traces hook Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also merge this first, to provide a deprecation warning for the old package/hook.
Fixes: #447