Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecate otel hook #449

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix: deprecate otel hook #449

merged 2 commits into from
Jul 12, 2023

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Jul 7, 2023 •
edited
Loading

Giving some warning and redirecting people to the new package.

See discussion here.

@toddbaert toddbaert requested a review from a team as a code owner July 7, 2023 20:24
@toddbaert toddbaert mentioned this pull request Jul 7, 2023
Merged
@toddbaert toddbaert changed the title fix!: deprecate otel hook fix: deprecate otel hook Jul 7, 2023
Kavindu-Dodan
Kavindu-Dodan approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good decision. Going forward we will benefit from this change as we have a single package with all telemetry hooks.

beeme1mr
beeme1mr approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we'll want to time this release with the release of the new hooks. We'll also want to mark the package as deprecated in NPM.

toddbaert and others added 2 commits July 12, 2023 09:17
@toddbaert
fix!: deprecate otel hook
a11156a 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert @Kavindu-Dodan
Update libs/hooks/open-telemetry/README.md
d7bd0a4 
Co-authored-by: Kavindu Dodanduwa <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert merged commit 58aa56c into main Jul 12, 2023
This was referenced Jul 12, 2023
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kavindu-Dodan Kavindu-Dodan Kavindu-Dodan approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@beeme1mr beeme1mr

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @Kavindu-Dodan