fixup: test names

Signed-off-by: Todd Baert <[email protected]>
open-feature · Jul 11, 2023 · 3f214a2 · 3f214a2
1 parent 997a16d
commit 3f214a2
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/libs/hooks/open-telemetry/src/lib/metrics/metrics-hook.spec.ts b/libs/hooks/open-telemetry/src/lib/metrics/metrics-hook.spec.ts
@@ -4,7 +4,7 @@ import {
   DataPoint,
   MeterProvider,
   MetricReader,
-  ScopeMetrics
+  ScopeMetrics,
 } from '@opentelemetry/sdk-metrics';
 import { ACTIVE_COUNT_NAME, ERROR_TOTAL_NAME, REQUESTS_TOTAL_NAME, SUCCESS_TOTAL_NAME } from '../constants';
 import { MetricsHook } from './metrics-hook';
@@ -34,7 +34,7 @@ describe(MetricsHook.name, () => {
   });
 
   describe(MetricsHook.prototype.before, () => {
-    it('should ', async () => {
+    it('should increment evaluation_active_count and evaluation_requests_total and set attrs', async () => {
       const FLAG_KEY = 'before-test-key';
       const PROVIDER_NAME = 'before-provider-name';
       const hook = new MetricsHook();
@@ -70,7 +70,7 @@ describe(MetricsHook.name, () => {
 
   describe(MetricsHook.prototype.after, () => {
     describe('variant set', () => {
-      it('should set all attributes, with variant equalling variant', async () => {
+      it('should increment evaluation_success_total and set attrs with variant = variant', async () => {
         const FLAG_KEY = 'after-test-key';
         const PROVIDER_NAME = 'after-provider-name';
         const VARIANT = 'one';
@@ -105,7 +105,7 @@ describe(MetricsHook.name, () => {
         ).toBeTruthy();
       });
 
-      it('should set all attributes, with variant equalling value', async () => {
+      it('should increment evaluation_success_total and set attrs with variant = value', async () => {
         const FLAG_KEY = 'after-test-key';
         const PROVIDER_NAME = 'after-provider-name';
         const VALUE = 1;
@@ -141,7 +141,7 @@ describe(MetricsHook.name, () => {
   });
 
   describe(MetricsHook.prototype.finally, () => {
-    it('should ', async () => {
+    it('should decrement evaluation_success_total and set attrs', async () => {
       const FLAG_KEY = 'finally-test-key';
       const PROVIDER_NAME = 'finally-provider-name';
       const hook = new MetricsHook();
@@ -167,7 +167,7 @@ describe(MetricsHook.name, () => {
   });
 
   describe(MetricsHook.prototype.error, () => {
-    it('should ', async () => {
+    it('should decrement evaluation_success_total and set attrs', async () => {
       const FLAG_KEY = 'error-test-key';
       const PROVIDER_NAME = 'error-provider-name';
       const ERROR_MESSAGE = 'error message';