fix: Implement equals for the ImmutableMetadata object

Signed-off-by: Thomas Poignant <[email protected]>
open-feature · Jul 17, 2023 · 9077751 · 9077751
1 parent bbb4008
commit 9077751
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/ImmutableMetadata.java b/src/main/java/dev/openfeature/sdk/ImmutableMetadata.java
@@ -1,5 +1,6 @@
 package dev.openfeature.sdk;
 
+import lombok.EqualsAndHashCode;
 import lombok.extern.slf4j.Slf4j;
 
 import java.util.HashMap;
@@ -10,6 +11,7 @@
  * through builder and accessors.
  */
 @Slf4j
+@EqualsAndHashCode
 public class ImmutableMetadata {
     private final Map<String, Object> metadata;
 

diff --git a/src/test/java/dev/openfeature/sdk/FlagEvaluationDetailsTest.java b/src/test/java/dev/openfeature/sdk/FlagEvaluationDetailsTest.java
@@ -45,4 +45,26 @@ public void sevenArgConstructor() {
         assertEquals(errorMessage, details.getErrorMessage());
         assertEquals(metadata, details.getFlagMetadata());
     }
+
+    @Test
+    @DisplayName("should be able to compare 2 FlagEvaluationDetails")
+    public void compareFlagEvaluationDetails(){
+        FlagEvaluationDetails fed1 = FlagEvaluationDetails.builder()
+                .reason(Reason.ERROR.toString())
+                .value(false)
+                .errorCode(ErrorCode.GENERAL)
+                .errorMessage("impossible to contact GO Feature Flag relay proxy instance")
+                .flagMetadata(ImmutableMetadata.builder().addString("metadata","1").build())
+                .build();
+
+        FlagEvaluationDetails fed2 = FlagEvaluationDetails.builder()
+                .reason(Reason.ERROR.toString())
+                .value(false)
+                .errorCode(ErrorCode.GENERAL)
+                .errorMessage("impossible to contact GO Feature Flag relay proxy instance")
+                .flagMetadata(ImmutableMetadata.builder().addString("metadata","1").build())
+                .build();
+
+        assertEquals(fed1,fed2);
+    }
 }