fix: [go-feature-flag] Make flag metadata optional #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
fix-go-feature-flag-metadata-npe
branch
from
b9cdc30 to
1bda560
Compare
Signed-off-by: itchyny <[email protected]>
itchyny
force-pushed
the
fix-go-feature-flag-metadata-npe
branch
from
1bda560 to
ed019bd
Compare
thomaspoignant
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Good catch @itchyny, this is a bug that I did not catch before.
|
Version |
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
NullPointerExceptionwhen receive data without flag metadata from go-feature-flag.Related Issues
Fixes #367 (comment).
Notes
The metadata in the flag configuration is an optional field.
Also see the following
omitemptytag which means that the field is not included in the response JSON if empty.Follow-up Tasks
How to test