Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ConfigCat provider #521

Merged
merged 18 commits into from
Nov 16, 2023
Merged

feat: Add ConfigCat provider #521

merged 18 commits into from
Nov 16, 2023

Conversation

liran2000
Copy link
Member

@liran2000 liran2000 commented Oct 31, 2023 •
edited
Loading

@z4kn4fein @laliconfigcat @novalisdenahi can review from ConfigCat point of view.

Readme describes the provider.

@liran2000 liran2000 requested a review from a team as a code owner October 31, 2023 06:46
@liran2000
clean unused
c9b96e4 
Signed-off-by: liran2000 <[email protected]>
@liran2000
clean unused - cont.
11a6232 
Signed-off-by: liran2000 <[email protected]>
laliconfigcat
laliconfigcat suggested changes Oct 31, 2023
View reviewed changes
Copy link

@laliconfigcat laliconfigcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your efforts! Awesome to see how easy it is to integrate our SDK with OpenFeature.

...igcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderConfig.java Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Show resolved Hide resolved
@liran2000
clean unused - cont.
4b255ba 
Signed-off-by: liran2000 <[email protected]>
novalisdenahi
novalisdenahi suggested changes Nov 2, 2023
View reviewed changes
...nfigcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java Outdated Show resolved Hide resolved
...nfigcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java Show resolved Hide resolved
...nfigcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java Show resolved Hide resolved
...nfigcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Outdated Show resolved Hide resolved
...s/configcat/src/main/java/dev/openfeature/contrib/providers/configcat/ConfigCatProvider.java Show resolved Hide resolved
@liran2000
- some refactor
44a3500 
- enrich tests

Signed-off-by: liran2000 <[email protected]>
@liran2000
enrich tests
9e355df 
Signed-off-by: liran2000 <[email protected]>
@liran2000
fix userId
05eca76 
Signed-off-by: liran2000 <[email protected]>
laliconfigcat
laliconfigcat approved these changes Nov 6, 2023
View reviewed changes
Copy link

@laliconfigcat laliconfigcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

toddbaert
toddbaert approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I left a few comments. I think my only real concern is this, which I would recommend changing.

@liran2000
Copy link
Member Author

Updated according to the comments.

toddbaert
toddbaert approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, thanks to @liran2000. Also @laliconfigcat and @novalisdenahi for the review!

@toddbaert toddbaert merged commit 879cc9d into open-feature:main Nov 16, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
@liran2000 liran2000 deleted the feature/configcat branch November 16, 2023 15:39
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
@renovate
chore(deps): update google-github-actions/release-please-action diges…
dd7d024 
…t to ca6063f (open-feature#521)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laliconfigcat laliconfigcat laliconfigcat approved these changes

@toddbaert toddbaert toddbaert approved these changes

@novalisdenahi novalisdenahi novalisdenahi approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees

@liran2000 liran2000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liran2000 @novalisdenahi @toddbaert @laliconfigcat