chore: fix coverage uploads to Codecov #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
=========================================
+ Coverage 0 86.86% +86.86%
=========================================
Files 0 12 +12
Lines 0 1370 +1370
=========================================
+ Hits 0 1190 +1190
- Misses 0 156 +156
- Partials 0 24 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
warber
force-pushed
the
test/fix-codecov-upload
branch
3 times, most recently
from
40aff65
to
e0d9e72
Compare
Write test reports to separate files and upload them separately Signed-off-by: Bernd Warmuth <[email protected]>
warber
force-pushed
the
test/fix-codecov-upload
branch
from
e0d9e72
to
e2f919a
Compare
warber
changed the title
aepfli
approved these changes
Nov 25, 2024
toddbaert
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes publishing test coverage results to Codecov.
The coverage results are now saved in two separate files,
coverage-unit.outandcoverage-e2e.out, preventing any overwrites during the execution of the two test suites. Additionally, each result is uploaded to Codecov separately, with distinct flags to logically differentiate them.Related Issues
fixes #304
How to test
https://app.codecov.io/github/open-feature/go-sdk/tree/warber%2Fgo-sdk%3Atest%2Ffix-codecov-upload/openfeature